This repository was archived by the owner on May 21, 2019. It is now read-only.
Update project to support Swift 4.2 and swift-sdk 1.1.0 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properties to reflect Swift 4.2
…tion api key instead of username and password
leitdeux
changed the title
AnthonyOliveri
suggested changes
Jan 2, 2019
Contributor
|
Thanks for making these updates @leitdeux! I left a few small recommendations, but otherwise it looks great. |
Contributor
Author
|
Thanks @AnthonyOliveri for reviewing my pull request. I've now added in the fixes you recommended-- cleaning up the Cartfile and removing the [weak self] syntax from those closures. Thanks again for kindly reviewing my code! |
AnthonyOliveri
approved these changes
Jan 3, 2019
Contributor
AnthonyOliveri
left a comment
AnthonyOliveri
left a comment
There was a problem hiding this comment.
Looks good. Thanks again!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates made to support Swift 4.2 and also updates to TextToSpeech method calls (listVoices, synthesize) to reflect the latest API. I've also updated Credentials.swift to use an API key instead of username and password.