Update tests #384
Merged
Update tests #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit speeds up the Dialog test suite by using a single dialog application instead of creating a new dialog application for each test. Note that some test errors were introduced and will be fixed in an upcoming commit.
This commit modifies the `getDialogFile` method to ensure that dialog files are downloaded to the user’s downloads directory with a unique name and proper extension.
- Verify that the file exists at the given path - Verify that the extension of the downloaded file is correct - Remove the downloaded file to avoid collisions with subsequent tests
The service is returning time in milliseconds since the Unix epoch instead of seconds. The resulting values are too large for a Swift `Int` and cannot be parsed by Freddy. These fields are optional, so that they will be populated after the bug has been fixed.
# Conflicts: # Source/DialogV1/Tests/DialogTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the tests for Dialog, Language Translator, and Text to Speech.