Adds Natural Language Understanding and fix a few bugs in the process #617

germanattanasio · 2017-03-16T20:09:09Z

Summary

Adds support for NLU thanks to @mkistler
Adds android-utils to build.gradle
Adds build.gradle to the examples
Only push javadoc for the src folder fixes Generate javadoc only for src files not test. #547

I will merge and do a release after that I fix #610

mkistler · 2017-03-16T23:35:14Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/ConceptsOptions.java

+   *
+   * @return the limit
+   */
+  public Integer getLimit() {


Getter name should be "limit" rather than "getLimit".

mkistler · 2017-03-16T23:36:26Z

...a/com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/ConceptsResult.java

+   *
+   * @return the text
+   */
+  public String getText() {


Getter methods should be "text", "relevance", rather than "getText", "getRelevance".

mkistler · 2017-03-16T23:49:59Z

...a/com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EmotionOptions.java

+/**
+ * Whether or not to return emotion analysis of the content.
+ */
+public class EmotionOptions extends GenericModel {


This class should have a builder.

mkistler · 2017-03-16T23:52:41Z

...va/com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EmotionResult.java

+   *
+   * @return the document
+   */
+  public DocumentEmotionResults getDocument() {


Getter methods should be "document", "targets" rather than "getDocument", "getTargets".

I'll stop commenting on this now. It just needs to be changed throughout.

mkistler · 2017-03-16T23:53:20Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EntitiesOptions.java

+/**
+ * Whether or not to return important people, places, geopolitical, and other entities detected in the analyzed content.
+ */
+public class EntitiesOptions extends GenericModel {


This class should have a builder.

mkistler · 2017-03-16T23:55:42Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/KeywordsOptions.java

+/**
+ * An option indicating whether or not important keywords from the analyzed content should be returned.
+ */
+public class KeywordsOptions extends GenericModel {


This class should have a builder.

mkistler · 2017-03-16T23:58:32Z

.../main/java/com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/Model.java

+  private String status;
+  /** Unique model ID. */
+  @SerializedName("model_id")
+  private String modelID;


I think the convention in the Java SDK is to use "Id" rather than "ID" (this differs from Swift by the way). So to adhere to that convention, this variable and its associated getters/setters should use "Id".

mkistler · 2017-03-17T00:06:05Z

...a/com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EmotionOptions.java

+   *
+   * @return the document
+   */
+  public Boolean isDocument() {


Do we want the "is" prefix on this getter? It seems to break the convention of just using the name for getters -- even for boolean values.

mkistler · 2017-03-17T00:09:49Z

...a/com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EmotionOptions.java

+    return targets;
+  }
+
+  /**


I think we do not want setters in this class, right?

mkistler · 2017-03-17T00:11:11Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EntitiesOptions.java

+   *
+   * @return the sentiment
+   */
+  public Boolean isSentiment() {


I think we don't want "is" in the getter name here.

mkistler · 2017-03-17T00:11:29Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/EntitiesOptions.java

+    return emotion;
+  }
+
+  /**


I think we do not want setters in this class.

mkistler · 2017-03-17T00:14:26Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/KeywordsOptions.java

+   *
+   * @return the sentiment
+   */
+  public Boolean isSentiment() {


I don't think we want "is" in these getter names.

mkistler · 2017-03-17T00:14:47Z

.../com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/KeywordsOptions.java

+    return emotion;
+  }
+
+  /**


I don't think we want setters in this class.

mkistler · 2017-03-17T00:16:40Z

...com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/RelationsOptions.java

+/**
+ * An option specifying if the relationships found between entities in the analyzed content should be returned.
+ */
+public class RelationsOptions extends GenericModel {


This class should have a builder.

mkistler · 2017-03-17T00:17:00Z

...com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/RelationsOptions.java

+    return model;
+  }
+
+  /**


I don't think we want setters in this class.

mkistler · 2017-03-17T00:18:03Z

...ibm/watson/developer_cloud/natural_language_understanding/v1/model/SemanticRolesOptions.java

+/**
+ * An option specifying whether or not to identify the subjects, actions, and verbs in the analyzed content.
+ */
+public class SemanticRolesOptions extends GenericModel {


I think we want a builder for this class.

mkistler · 2017-03-17T00:18:26Z

...ibm/watson/developer_cloud/natural_language_understanding/v1/model/SemanticRolesOptions.java

+   *
+   * @return the keywords
+   */
+  public Boolean isKeywords() {


I don't think we want "is" in this getter name.

mkistler · 2017-03-17T00:18:46Z

...ibm/watson/developer_cloud/natural_language_understanding/v1/model/SemanticRolesOptions.java

+    return entities;
+  }
+
+  /**


I don't think we want setters in this class.

mkistler · 2017-03-17T00:19:44Z

...com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/SentimentOptions.java

+/**
+ * An option specifying if sentiment of detected entities, keywords, or phrases should be returned.
+ */
+public class SentimentOptions extends GenericModel {


I think we want a builder for this class.

mkistler · 2017-03-17T00:20:10Z

...com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/SentimentOptions.java

+   *
+   * @return the document
+   */
+  public Boolean isDocument() {


I don't think we want "is" in the getter name here.

mkistler · 2017-03-17T00:20:27Z

...com/ibm/watson/developer_cloud/natural_language_understanding/v1/model/SentimentOptions.java

+    return targets;
+  }
+
+  /**


I don't think we want setters in this class.

Fixes #569

Mike Kistler and others added 27 commits March 11, 2017 14:54

First version of generated nlu sdk - builds without errors.

41ac52e

Minor improvements

e23bf2e

More improvements - fold arbitrary JSON objs into referencing properties

31059fd

Reg using latest NLU swagger plus descriptions & opIds

829fee9

Text flow app description

7900ac0

number should map to Double

5c74d19

set up testing structure

457058f

Move test to v1 directory

dba17af

Improvements to codegen

15e176a

Add integration test file

43bb78a

First integration test passing

be46be2

Add more tests

9cd7bad

More integration tests

6593220

Improve and add more integration tests

02bffac

Three more integration tests

518d4e4

All Swift integration tests ported and running.

fd4c256

Eliminate unused imports

aaffe47

Fix more checkstyle errors

ad93116

Merge branch 'master' into nlu-codegen

ee82690

🐛 Add android-utils to gradle

a21331f

📝 Only publish src javadoc fixes #547

72a26b3

🚜 remove " from build.gradle

d571aff

💚 Update gradle wrapper

a7e62a2

🆕 Added Natural Language Understanding

356b2d9

📝 Updated CHANGELOG

4e46155

📝 Update README

034f3a0

🐛 Update examples with a gradle file

61ac3f3

germanattanasio added general-sdk in progress labels Mar 16, 2017

germanattanasio requested a review from mkistler March 16, 2017 20:09

mkistler reviewed Mar 16, 2017

View reviewed changes

mkistler reviewed Mar 17, 2017

View reviewed changes

germanattanasio added 7 commits March 16, 2017 23:21

📝 Add NLU package.java

dcb9faf

🐛 Add knoledgeGraph to Concepts in AlchemyLanguage

a228faa

Fixes #569

Update variable name

f954bff

🎨 Update NLU builder methods

10de33d

📝 Update NLU javadoc

c751f12

🐛 switch from modelID to modelId

f35461d

germanattanasio merged commit 1c43677 into master Mar 20, 2017

germanattanasio mentioned this pull request Mar 20, 2017

NLU generated SDK code #619

Closed

Adds Natural Language Understanding and fix a few bugs in the process #617

Adds Natural Language Understanding and fix a few bugs in the process #617

Uh oh!

Conversation

germanattanasio commented Mar 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

germanattanasio commented Mar 16, 2017 •

edited

Loading