This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Feat(Error): Adds descriptive error messages #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds descriptive error messages. - Moves more messages to externalization. - Condition checking of the payload in the UI. DCO 1.1 Signed-off-by: Sudheer Reddy Puthana <sputhan@us.ibm.com>
- Add missing file DCO 1.1 Signed-off-by: Sudheer Reddy Puthana <sputhan@us.ibm.com>
DCO 1.1 Signed-off-by: Sudheer Reddy Puthana <sputhan@us.ibm.com>
| @@ -134,7 +134,13 @@ public void run() { | |||
|
|
|||
| } catch (Exception e) { | |||
| logger.error(Messages.getString("SetupThread.ERROR_COLLECTION_INIT") + e.getMessage()); //$NON-NLS-1$ | |||
| updateConfigObject("0",Constants.NOT_READY, Messages.getString("SetupThread.ERROR"), Messages.getString("SetupThread.CHECK_LOGS")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ | |||
| if (e.getClass().getSimpleName().equalsIgnoreCase("UnauthorizedException")) { | |||
There was a problem hiding this comment.
can you just do an if (e instanceof UnauthorizedException) ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCO 1.1 Signed-off-by: Sudheer Reddy Puthana sputhan@us.ibm.com