Merge pull request backstage#301 from spotify/rugvip/shell

cli: use shell option to fix build issues on windows
watargolla · Mar 17, 2020 · fd90d8a · fd90d8a
2 parents e09bf89 + 3772c82
commit fd90d8a
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 4 deletions.
diff --git a/packages/cli/src/commands/plugin/build.ts b/packages/cli/src/commands/plugin/build.ts
@@ -37,7 +37,7 @@ export default async (cmd: Command) => {
 
   try {
     await copyStaticAssets();
-    const result = spawnSync('tsc', args, { stdio: 'inherit' });
+    const result = spawnSync('tsc', args, { stdio: 'inherit', shell: true });
     if (result.error) {
       throw result.error;
     }

diff --git a/packages/cli/src/commands/plugin/lint.ts b/packages/cli/src/commands/plugin/lint.ts
@@ -25,7 +25,7 @@ export default async (cmd: Command) => {
   }
 
   try {
-    const result = spawnSync('web-scripts', args, { stdio: 'inherit' });
+    const result = spawnSync('web-scripts', args, { stdio: 'inherit', shell: true });
     if (result.error) {
       throw result.error;
     }

diff --git a/packages/cli/src/commands/plugin/testCommand.ts b/packages/cli/src/commands/plugin/testCommand.ts
@@ -29,7 +29,7 @@ export default async (cmd: Command) => {
   }
 
   try {
-    const result = spawnSync('web-scripts', args, { stdio: 'inherit' });
+    const result = spawnSync('web-scripts', args, { stdio: 'inherit', shell: true });
     if (result.error) {
       throw result.error;
     }

diff --git a/packages/cli/src/commands/watch-deps/child.ts b/packages/cli/src/commands/watch-deps/child.ts
@@ -23,6 +23,7 @@ export function startChild(args: string[]) {
   const child = spawn(command, commandArgs, {
     env: { FORCE_COLOR: 'true', ...process.env },
     stdio: ['inherit', 'pipe', 'pipe'],
+    shell: true,
   });
 
   // We need to avoid clearing the terminal, or the build feedback of dependencies will be lost

diff --git a/packages/cli/src/commands/watch-deps/compiler.ts b/packages/cli/src/commands/watch-deps/compiler.ts
@@ -31,6 +31,7 @@ export function startCompiler(pkg: Package, log: Logger) {
     cwd: pkg.location,
     env: { FORCE_COLOR: 'true', ...process.env },
     stdio: 'pipe',
+    shell: true,
   });
 
   watch.stdin.end();

diff --git a/scripts/cli-e2e-test.js b/scripts/cli-e2e-test.js
@@ -68,7 +68,7 @@ function spawnPiped(cmd, options) {
     };
   }
 
-  const child = spawn(cmd[0], cmd.slice(1), { stdio: 'pipe', ...options });
+  const child = spawn(cmd[0], cmd.slice(1), { stdio: 'pipe', shell: true, ...options });
   child.on('error', handleError);
   child.on('exit', code => {
     if (code) {