Add userSignupFields types to public signup functions

[FranjoMindek]

Fixes #2592

[FranjoMindek]

Prisma always ships this field. Do we want to keep it?

[FranjoMindek]

We don't really use types here, but it will help once we hopefully escape this template madness.

[FranjoMindek]

Type result:

For prisma schema:

[FranjoMindek]

OAuth thingies are done on server out of the reach of the user. Don't think we have anything to do there.

[infomiho]

I think we should approach this from a different angle because I think the current implementation lies with types 😄

The types lie

Let's say that my User model looks like this:

model User {
  id Int @id @default(autoincrement())

  isOnAfterSignupHookCalled Boolean @default(false)
  isOnAfterLoginHookCalled  Boolean @default(false)

  tasks   Task[]
  address String?
  votes   TaskVote[]
}

I get the following extra fields on the signup fn:

type UserSignupFieldsData = {
    isOnAfterSignupHookCalled?: boolean | undefined;
    isOnAfterLoginHookCalled?: boolean | undefined;
    address?: string | null | undefined;
    tasks?: Prisma.TaskCreateNestedManyWithoutUserInput | undefined;
    votes?: Prisma.TaskVoteCreateNestedManyWithoutUserInput | undefined;
}

But my extra user signup fields are defined like this:

export const userSignupFields = defineUserSignupFields({
  address: (data) => {
    if (typeof data.address !== 'string') {
      throw new Error('Address is required.')
    }
    if (data.address.length < 10) {
      throw new Error('Address must be at least 10 characters long.')
    }
    return data.address
  },
})

On the client, I can call the signup fn like this:

await signup({ email, password, isOnAfterLoginHookCalled: true })

without any type errors. But the runtime code won't save the isOnAfterSignupHookCalled field value.

I'd advise maybe getting the type of the userSignupFields user-defined fn to get the correct types.

address should ideally be required

One extra thing to note here, address is validated in userSignupFields but I guess we can't infer that it should be required unless we redefine how users provide us validation for the extra fields (e.g. providing us with a Zod schema).

await signup({ email, password, address: undefined })

That's out of scope for this PR, but we might want to define an issue for that if we can formulate it clearly.

[FranjoMindek]

Throws error if user uses keys outside of UserSignupFields.
Required since we use generics now.

[FranjoMindek]

On fail its {} so it doesn't change the type of objects which extend this type.

[FranjoMindek]

Someone didn't use prettier, should I exclude these changes from this PR?

[FranjoMindek]

Type should be inferred properly now while keeping the type guard at defineUserSignupFields unchanged.

Reminder for myself not to import client and sever stuff at the same time again 😄 .
Screwed my wasp project and took me into the wrong path during debugging.