capi: Remove dynamic allocation in find_exported_function#791
Draft
capi: Remove dynamic allocation in find_exported_function#791
Conversation
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 99.23% 99.16% -0.07%
==========================================
Files 79 79
Lines 12394 12396 +2
==========================================
- Hits 12299 12293 -6
- Misses 95 103 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PoC to get rid of extra dynamic allocation in C API for imported/exported functions at the expense of
FizzyExternalFunction, but the upside is thatfizzy_free_exported_functionis removed)