Open
Conversation
Collaborator
Author
|
Haswell 4 GHz, GCC10 LTO |
gumb0
reviewed
Nov 11, 2020
chfast
force-pushed
the
skip_nop_instructions
branch
from
225275a to
6acac3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 69 69
Lines 9622 9626 +4
=======================================
+ Hits 9465 9469 +4
Misses 157 157 |
chfast
force-pushed
the
skip_nop_instructions
branch
from
6acac3b to
da8c473
Compare
Collaborator
Author
|
Last 4 commits to be squashed, but leaving them for the review period. |
Collaborator
Author
|
EPYC 7601 2.2 GHz, GCC 10 |
Collaborator
Author
|
EPYC 7601 2.2 GHz, GCC10 LTO |
gumb0
approved these changes
Nov 12, 2020
Collaborator
|
Test suggestion: function containing all skipped opcodes, check that it's parsed to single |
Collaborator
Author
Added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally included in #622.
I can't get good measurement of the performance on Haswell (I will try other architectures later).
But this is rather no-brainer as we simply execute less interpreter loop iterations and the "internal code" is smaller.