Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 56 56
Lines 8660 8660
=======================================
Hits 8550 8550
Misses 110 110 |
Member
Author
Collaborator
|
How long does it run? |
Collaborator
It looks like it runs 2x faster than the slowest pairing benchmark. Fine to me then. |
chfast
approved these changes
Jun 25, 2020
Member
Author
|
@cdetrio do you have a newer/different build of this? |
Member
Author
|
My benchmarks between 0.2.0 and 0.3.0: vs |
9865474 to
7cb64f5
Compare
Source: https://github.com/ewasm/scout.ts/blob/81ad848fd41a3a20e59571376b80bfea3c555d05/assembly/bls12-pairing/out/main_with_websnark.wasm Co-authored-by: cdetrio <cdetrio@gmail.com>
Collaborator
|
Can we finally merge this? |
Member
Author
@chfast I think the only delay here was whether this would cause anything else to be GPL-3.0, because this code is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.