-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add pull after checking out master
for Benchmark CI
#460
Conversation
Thanks @sergejparity for the quick fix! Let's wait for the benchmark results. |
CRITERION BENCHMARKS
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Since you are already at it ... ^.^ Could you please make use of the more efficient (non-bench) GitLab runners? Or is there a technical/practical reason why not to use those for benchmarking even though they are faster? (Still a lot slower than my 2015 laptop ...)
master
for Benchmark CI
Main reason is to deliver trustworthy results. So we can be sure that difference between tests executed against |
sounds reasonable, okay 👍 |
It appears that in sometimes
master
branch is out of sync.Like here https://gitlab.parity.io/parity/mirrors/wasmi/-/jobs/1868177#L29
This PR fixes that