Skip to content

Redesign StackLimits API for Engine's config #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 12, 2025
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Aug 12, 2025

Closes #1629.

  • Deprecated StackLimits type.
  • Deprecated Config::set_stack_limits and Config::cached_stacks methods.
  • Add Config::set_{min_stack_height,max_stack_height,max_cached_stacks}.
  • Add and use StackConfig internally.

- Removed `StackLimits`
- Removed `Config::set_stack_limits` method
- Add `Config::set_{min_stack_height,max_stack_height,max_cached_stacks}`
- Add and use `StackConfig` internally
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 31.57895% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (9037273) to head (2911597).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/limits/stack.rs 32.14% 19 Missing ⚠️
crates/wasmi/src/engine/config.rs 5.55% 17 Missing ⚠️
crates/fuzz/src/oracle/wasmi.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1631      +/-   ##
==========================================
- Coverage   70.92%   70.77%   -0.16%     
==========================================
  Files         181      181              
  Lines       15482    15512      +30     
==========================================
- Hits        10980    10978       -2     
- Misses       4502     4534      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit 020a3f6 into main Aug 12, 2025
17 of 19 checks passed
@Robbepop Robbepop deleted the rf-deprecate-stack-limits branch August 12, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate or redesign StackLimits configuration
1 participant