-
Notifications
You must be signed in to change notification settings - Fork 314
Add new logical comparators for and
, or
and xor
+ negations
#1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is applied for i32.eq and no longer only for i32.eqz.
This is mostly important for fusing bitwise i32.{and,or,xor} into their logical versions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
- Coverage 71.65% 71.44% -0.22%
==========================================
Files 175 175
Lines 16149 16301 +152
==========================================
+ Hits 11572 11646 +74
- Misses 4577 4655 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
and
, or
and xor
and
, or
and xor
+ negations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1483.
i32.eqz
to also work withi32.eq
with a zerolhs
orrhs
immediate.i32.ne
with a zerolhs
orrhs
immediate.bitand
,bitor
andbitxor
are converted into their logical variants instead.ToDo
i{32,64}.{and,or,xor}
->i{32,64}.bit{and,or,xor}
: bitwise versionsi32.{and,or,xor,nand,nor,xnor}
: logical versions fori32
i64.{and,or,xor,nand,nor,xnor}
: logical versions fori64
branch_i32.{nand,nor,xnor}
: new cmp+branch instructions fori32
branch_i64.{and,or,xor,nand,nor,xnor}
: new cmp+branch instructions fori64
cmp+br
translation tests