Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wasmi_core::memory submodule #1401

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Mar 19, 2025

This now exposes load, load_at, store and store_at functions additionally to the load_extend and store_wrap ones from the wasmi_core::memory submodule.

This way we no longer require the weird WrapInto and ExtendInto impls for T -> T which made no sense.
Furthermore, this is going to simplify implementation of #1395.

This now exposes `load`, `load_at`, `store` and `store_at` functions additionally to the load_extend and store_wrap ones. This way we no longer require the weird `WrapInto` and `ExtendInto` impls for `T -> T`.
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (2b4fa76) to head (02469fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1401      +/-   ##
==========================================
+ Coverage   70.48%   70.52%   +0.03%     
==========================================
  Files         157      157              
  Lines       14398    14414      +16     
==========================================
+ Hits        10149    10166      +17     
+ Misses       4249     4248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit 6735bf9 into main Mar 19, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-refactor-memory-module branch March 19, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant