Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the mangle-symbols feature #1312

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: Add the mangle-symbols feature #1312

merged 2 commits into from
Nov 21, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Nov 21, 2024

As per title.

@Robbepop
Copy link
Member

Robbepop commented Nov 21, 2024

@xdoardo Thank you!

I made a small mistake when I told you that it would be best to enable this feature by default. I think it is better to disable it by default.

Formatting check can be satisfied by quickly running: cargo +nightly fmt.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.58%. Comparing base (c472297) to head (e87de7b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   81.58%   81.58%           
=======================================
  Files         306      306           
  Lines       25271    25271           
=======================================
  Hits        20617    20617           
  Misses       4654     4654           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work! LGTM

@Robbepop Robbepop merged commit 37a8116 into wasmi-labs:main Nov 21, 2024
19 checks passed
Robbepop pushed a commit that referenced this pull request Nov 27, 2024
Revert "feat: Add the `mangle-symbols` feature (#1312)"

This reverts commit 37a8116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants