This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
feat: add custom CA support to the NATS provider, rework Redis TLS #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
requested review from
autodidaddict and
brooksmtownsend
as code owners
protochron
force-pushed
the
nats_ca_cert
branch
2 times, most recently
from
b30aff3
to
c9af343
Compare
protochron
force-pushed
the
nats_ca_cert
branch
from
c9af343
to
b8b734f
Compare
This PR does two things: * adds the ability to add a custom root CA to each NATS linkdef so that you can connect to servers that might be secured with self-signed certs * reworks how the Redis provider depends on rustls and other dependencies so that the webroot PKI certs are embedded. This removes a dependency on the host for anything TLS related. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
nats_ca_cert
branch
from
b8b734f
to
a1733e6
Compare
connorsmith256
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR does two things:
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification