Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for per app credentials when sending mails #6

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Add support for per app credentials when sending mails #6

merged 4 commits into from
Oct 16, 2024

Conversation

maminrayej
Copy link

No description provided.

@Arshia001 Arshia001 self-requested a review October 16, 2024 07:19
Arshia001
Arshia001 reviewed Oct 16, 2024
View reviewed changes
wasix-test-run.sh Outdated Show resolved Hide resolved
ext/standard/mail.c Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Oct 16, 2024
View reviewed changes
ext/standard/mail.c Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Oct 16, 2024
View reviewed changes
ext/standard/mail.c Outdated Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Oct 16, 2024
View reviewed changes
ext/standard/mail.c Outdated Show resolved Hide resolved
@syrusakbary
Copy link

Sorry for the back and forth, after reading the values that Laravel expects we can simply use:

MAIL_HOST=smtp.example.com
MAIL_PORT=587
MAIL_USERNAME=mail@example.com
MAIL_PASSWORD=yoursecretpassword

Extra info: https://medium.com/@info.subashthapa/environment-variables-for-sending-email-in-cpanel-laravel-6e83c89fac25

@maminrayej maminrayej merged commit 5c008af into 8.3.4-wasix Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arshia001 Arshia001 Arshia001 left review comments

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maminrayej @syrusakbary @theduke @Arshia001