code review

washad · Feb 2, 2023 · 461492d · 461492d
1 parent c215383
commit 461492d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tests/screen.py b/tests/screen.py
@@ -76,7 +76,9 @@ def switch_to(self, tab_id: int) -> None:
             self.selenium.switch_to.window(self.selenium.window_handles[tab_id])
 
     def should_contain(self, text: str) -> None:
-        assert self.selenium.title == text or self.find(text), f'could not find "{text}"'
+        if self.selenium.title == text:
+            return
+        self.find(text)
 
     def should_not_contain(self, text: str) -> None:
         assert self.selenium.title != text

diff --git a/tests/test_dialog.py b/tests/test_dialog.py
@@ -1,6 +1,5 @@
 from typing import List
 
-from selenium.webdriver.common.action_chains import ActionChains
 from selenium.webdriver.common.keys import Keys
 
 from nicegui import ui