Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create strings.xml for Farsi/Persian #134

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Create strings.xml for Farsi/Persian #134

merged 3 commits into from
Dec 22, 2023

Conversation

yamin8000
Copy link
Contributor

waseefakhtar
waseefakhtar reviewed Dec 22, 2023
View reviewed changes
Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @yamin8000! I just notice some phrases are still in English and not translated. Are you going to translate them too? :)

@waseefakhtar waseefakhtar added this to the 1.3 milestone Dec 22, 2023
@yamin8000
Copy link
Contributor Author

Looks good @yamin8000! I just notice some phrases are still in English and not translated. Are you going to translate them too? :)

I edited using my browser so editing parametric ones was a little difficult especially since Farsi is right to left I feared I may mess them up so I just left them for now to edit them later using a proper editor or even build it using AS to test it.

@yamin8000
Copy link
Contributor Author

Looks good @yamin8000! I just notice some phrases are still in English and not translated. Are you going to translate them too? :)

I fixed the remaining ones.

waseefakhtar
waseefakhtar approved these changes Dec 22, 2023
View reviewed changes
Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now @yamin8000! 🚀 Thanks for your contribution! :)

@waseefakhtar waseefakhtar merged commit 6c84bbd into waseefakhtar:main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waseefakhtar waseefakhtar waseefakhtar approved these changes

Assignees

@yamin8000 yamin8000

Labels
localization
Projects
Dose App
Status: Ready 🚀
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@yamin8000 @waseefakhtar