Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds IridescentView library #297

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Adds IridescentView library #297

merged 1 commit into from
Feb 13, 2021

Conversation

alexandrehtrb
Copy link
Contributor

Hello,

I would like to add the IridescentView library.

Adds IridescentView library
@waandroid
Copy link

would like to add the IridescentView library as well

@alexandrehtrb
Copy link
Contributor Author

@wasabeef @pgreze , could you please review whether this is a good addition for the list?

@pgreze
Copy link
Collaborator

pgreze commented Feb 10, 2021

@alexandrehtrb thank you for adding this new library.
I think there's several other improvements that should be done before merging it:

  1. jcenter will be closed soon. At least for new projects, they should use a more future-proof publication channels (like Maven Central)
  2. default README is not in English. I would advise to use it as the default language before pushing it in this EN first library collection.

@alexandrehtrb
Copy link
Contributor Author

Hello @pgreze ,

I took care of the improvements you mentioned!
The library is now available on Maven Central and the default README is in english.

@pgreze
Copy link
Collaborator

pgreze commented Feb 13, 2021

@alexandrehtrb thank you for addressing comments.

@pgreze pgreze merged commit 2ea236d into wasabeef:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants