-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnimatedBottomBar library #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure your 2 images are displayed correctly on 1 line.
About sorting the README, there's plans to use something more fair than an alphabetic order, but thx for the suggestion.
@pgreze I'm not sure what you mean by that, since the height is a lot smaller than the width, it makes more sense for them to be placed underneath each other? |
@Droppers in any case, only 1 gif is displayed. |
Do you mean changing the width of the gifs to 50%? Sorry for the misunderstanding, but I am just confused why that would be beneficial, the gifs underneath each other takes up half the vertical space of the majority of all other libraries 😅? But if having multiple gifs is a problem, I can remove the second gif. |
@Droppers have 2 gifs is not an issue, I'm just comparing your new addition: With for example this existing line that could add 2 gifs in 1 line without compromising on the final result: You can access the Markdown preview by clicking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for addressing comments 👍
Not sure if allowed, but I have added my own library: https://github.com/Droppers/AnimatedBottomBar
Also, completely unrelated, wouldn't it make more sense if these lists were alphabetically sorted? Maybe in the form of a GitHub action that runs a script sorting the Markdown tables? Not sure how realistic this would be tough, just an idea.
Edit: pretty easy, made a script that sorts the README file:
https://gist.github.com/Droppers/6c4d401d201353bd032f829eec12b95f