fix: enable IME input on Linux and FreeBSD#11618
Conversation
Call set_ime_allowed(true) on Linux and FreeBSD window creation, mirroring the existing Windows behavior. Without this, winit never enables the text-input-v3 protocol on Wayland, preventing fcitx5, ibus, and other IME frameworks from receiving input events. Fixes: warpdotdev#9383 Fixes: warpdotdev#5279
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cislunarspace on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR enables winit IME support on Linux/FreeBSD by calling set_ime_allowed(true) after window creation, matching the existing Windows behavior.
Concerns
- For this user-facing IME input change, please include screenshots or a screen recording demonstrating it working end to end on Linux/FreeBSD with an IME candidate window and committed text. The current PR description has only an unchecked manual test plan, so reviewers do not have visual evidence for the behavior change.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@cla-bot check Hi team, I've completed the CLA signing and local verification:
Please let me know if anything else is needed. Thanks! |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
oz-for-oss
Bot
dismissed
their stale review
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR enables winit IME input on Linux and FreeBSD by calling set_ime_allowed(true) after successful window creation, matching the existing Windows behavior.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR enables winit IME support during window creation on Linux and FreeBSD, matching the existing Windows behavior so IME composition events can be delivered for CJK and other composed input.
Concerns
- No blocking correctness, spec-alignment, or security concerns found in the changed lines.
- The PR description includes screenshots demonstrating the user-facing IME behavior after the fix.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Summary
Enables IME (Input Method Editor) support on Linux and FreeBSD by calling `set_ime_allowed(true)` during window creation, matching the existing Windows behavior.
Problem
On Linux/Wayland, Warp never activated the input method framework, making CJK input completely non-functional. The root cause was that `set_ime_allowed(true)` was only called inside a `#[cfg(windows)]` block.
Without this call, winit never sends `zwp_text_input_v3.enable()` to the Wayland compositor, so fcitx5, ibus, and other IME frameworks never receive keyboard input events.
Fix
Added a `#[cfg(any(target_os = "linux", target_os = "freebsd"))]` block that calls `set_ime_allowed(true)` on the created window, mirroring the Windows implementation.
Screenshots
Before fix: fcitx5 candidate window does not appear, no CJK input possible.
After fix: fcitx5 candidate window appears and text commits correctly:
fcitx5 pinyin candidate window visible in Warp terminal
Chinese text successfully committed into Warp terminal
Related Issues
CHANGELOG-BUG-FIX: Fixed IME input not working on Linux and FreeBSD by enabling winit IME support during window creation.
Test Plan