feat: improved sell logic #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fdundjer
commented
Apr 27, 2024
•
fdundjer
commented
- Add trailing stop loss
- Add cache for filters
- Add stop sell when the max loss occurred
- Add option to handle multiple tokens at the time
bologer
reviewed
Apr 27, 2024
|
I can't run this version on my end, and stuck with initial bot running, wonder why @fdundjer And when it's running, it's stuck after some time (15 minutes) |
Tested, seems to work fine. Could be your RPC? |
kapocius
added a commit
to kapocius/warp-trading-bot
that referenced
this pull request
May 6, 2024
kapocius
reviewed
May 6, 2024
|
|
||
| if (this.config.skipSellingIfLostMoreThan > 0) { | ||
| const stopSellingFraction = this.config.quoteAmount | ||
| .mul(this.config.skipSellingIfLostMoreThan) |
There was a problem hiding this comment.
This should be 100 - skipSellingIfLostMoreThan
If value is 90, stopSellingAmount is 90%
There was a problem hiding this comment.
I'll check and update the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.