Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in-flight requests for warm metal driver #77

Closed
4 tasks
vadasambar opened this issue Nov 30, 2023 · 5 comments
Closed
4 tasks

Support in-flight requests for warm metal driver #77

vadasambar opened this issue Nov 30, 2023 · 5 comments
Assignees
Labels

Comments

@vadasambar
Copy link
Contributor

vadasambar commented Nov 30, 2023

Most of the context around this can be found in the discussion in #71 (comment)

TL:DR;

  1. warm metal can put pressure on disks (via CRI/containerd)
  2. having a way to queue requests instead of processing them immediately can distribute the load on the disks

TODO

  • decide an approach to implement this
  • create a PR
  • get reviews
  • DONE
@vadasambar
Copy link
Contributor Author

Going through https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3673-kubelet-parallel-image-pull-limit to understand how kubelet is implementing it.

@vadasambar
Copy link
Contributor Author

^ basically uses a buffered channel to limit max in-flight pulls. csi-driver-image can use a similar approach. Started a WIP PR: #81

@mugdha-adhav
Copy link
Collaborator

@vadasambar assigning this issue to you as you have already started working on it.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Apr 13, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants