Skip to content

Conversation

@spc-28
Copy link
Contributor

@spc-28 spc-28 commented Oct 14, 2024

This pull request includes changes to the source/utils/commit.js file to enhance the user interface and improve code readability. The most important changes include adding new imports for UI components, introducing a gradient and big text for a more engaging user interface, and minor code formatting improvements.

Enhancements to User Interface:

  • source/utils/commit.js: Added imports for info, BigText, Gradient, and Newline from respective modules to enhance the user interface.
  • source/utils/commit.js: Introduced a gradient and big text to display a motivational message and additional information like version and author in the askForCommitMessage function.

Code Formatting Improvements:

  • source/utils/commit.js: Improved code readability by combining else with the previous closing bracket in the askForCommitMessage function.

@spc-28
Copy link
Contributor Author

spc-28 commented Oct 14, 2024

Hey @warengonzaga , I have fixed the problem and its working fine for now. But i will refine this code more.

Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can make the logo/branding dynamic? Like we can we create a component file for it then dynamically add it to any event happening within the app? @spc-28

@warengonzaga warengonzaga changed the title Fix/prompt with the logo 🐛 fix: logo/branding not appearing upon prompt Oct 15, 2024
@warengonzaga warengonzaga added fix Bug Fix (PR) hacktoberfest-accepted Hacktoberfest (PR) labels Oct 15, 2024
@spc-28
Copy link
Contributor Author

spc-28 commented Oct 15, 2024

ok i will code the branding into a component, so it can be used in the app wherever required.

@spc-28
Copy link
Contributor Author

spc-28 commented Oct 15, 2024

@warengonzaga I have created the Logo component. Please let me know if any more changes to be made.

Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it and I can see the logo as component.

@warengonzaga warengonzaga merged commit 3ec5f01 into warengonzaga:dev Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug Fix (PR) hacktoberfest-accepted Hacktoberfest (PR)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants