Feature: Add WordPress specific images#25
Open
michielgerritsen wants to merge 2 commits intowardenenv:mainfrom
Open
Feature: Add WordPress specific images#25michielgerritsen wants to merge 2 commits intowardenenv:mainfrom
michielgerritsen wants to merge 2 commits intowardenenv:mainfrom
Conversation
bap14
suggested changes
Mar 6, 2024
| @@ -0,0 +1,20 @@ | |||
| ARG ENV_SOURCE_IMAGE | |||
| ARG PHP_VERSION | |||
| FROM ${ENV_SOURCE_IMAGE}:${PHP_VERSION}-magento2 | |||
Member
There was a problem hiding this comment.
@michielgerritsen Why are you coming from the magento2 variant of the image? Shouldn't this be wordpress?
Author
There was a problem hiding this comment.
Whoops, that's not correct. Thanks for noticing!
Member
|
@navarr I wonder if for things like this, just adding tools to the PHP images, if it would be better to have a robust docker entrypoint script that will download / install those tools on start. Potentially even defining those locations as volumes so changes are persisted between restarts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My biggest pet peeve with Warden is that Composer projects don't have WP CLI available, similar to Magerun for Magento. This PR tries to solve it by adding images for WordPress.