Skip to content

fix(docs): 아이콘 문서 페이지 아이콘 색상 지정#534

Merged
Sh031224 merged 1 commit intomainfrom
fix/sh031224/icon-doc-color
Apr 8, 2026
Merged

fix(docs): 아이콘 문서 페이지 아이콘 색상 지정#534
Sh031224 merged 1 commit intomainfrom
fix/sh031224/icon-doc-color

Conversation

@Sh031224
Copy link
Copy Markdown
Collaborator

@Sh031224 Sh031224 commented Apr 8, 2026

변경 사항

아이콘 문서 페이지(docs/src/features/docs/components/foundations/icons/collections)에서 아이콘 색상이 지정되지 않던 이슈를 수정했습니다.

  • iconItemStylecolor: ${theme.semantic.label.normal}을 명시적으로 지정
  • 아이콘이 상위 요소의 색상을 상속받지 않고 디자인 토큰 값을 사용하도록 수정

🤖 Generated with Claude Code

Summary by CodeRabbit

출시 노트

  • 스타일
    • 아이콘 항목의 색상 스타일을 테마의 의미적 색상 시스템과 일치하도록 업데이트했습니다.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Sh031224 Sh031224 self-assigned this Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

요약

아이콘 항목의 기본 스타일에 의미론적 라벨 색상을 추가하는 단순 스타일 수정입니다.

변경 사항

코호트 / 파일 요약
아이콘 스타일 업데이트
docs/src/features/docs/components/foundations/icons/collections/style.ts
iconItemStyle의 기본 CSS에 color: ${theme.semantic.label.normal};을 추가하여 아이콘 항목의 기본 텍스트 색상을 설정합니다.

예상 코드 리뷰 노력

🎯 1 (Trivial) | ⏱️ ~2분

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Pull request 제목이 변경 사항의 핵심을 명확하게 설명하고 있습니다. 아이콘 문서 페이지의 아이콘 색상 지정이라는 주요 변경 내용을 정확히 반영하고 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sh031224/icon-doc-color

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sh031224 Sh031224 added the documentation Improvements or additions to documentation label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docs/src/features/docs/components/foundations/icons/collections/style.ts (1)

1-3: 임포트 구성을 약간 개선할 수 있습니다.

동일한 패키지에서 가져오는 일반 임포트와 타입 임포트를 하나의 그룹으로 묶는 것을 고려해보세요.

♻️ 제안하는 임포트 구성
-import { addOpacity, css, respondTo } from '@wanteddev/wds';
-
 import type { Theme } from '@wanteddev/wds';
+import { addOpacity, css, respondTo } from '@wanteddev/wds';
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/src/features/docs/components/foundations/icons/collections/style.ts`
around lines 1 - 3, Group the imports from the same package into a single
statement: replace the two separate imports that reference '@wanteddev/wds' (the
values addOpacity, css, respondTo and the type Theme) with one consolidated
import that brings in addOpacity, css, respondTo and the type Theme (using a
type import or `type Theme`) in the same line so the symbols addOpacity, css,
respondTo and Theme are imported together.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@docs/src/features/docs/components/foundations/icons/collections/style.ts`:
- Around line 1-3: Group the imports from the same package into a single
statement: replace the two separate imports that reference '@wanteddev/wds' (the
values addOpacity, css, respondTo and the type Theme) with one consolidated
import that brings in addOpacity, css, respondTo and the type Theme (using a
type import or `type Theme`) in the same line so the symbols addOpacity, css,
respondTo and Theme are imported together.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2a6f5b26-8171-4219-9304-43e4f9c2369e

📥 Commits

Reviewing files that changed from the base of the PR and between 391818a and 4fff595.

📒 Files selected for processing (1)
  • docs/src/features/docs/components/foundations/icons/collections/style.ts

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🚀 Preview

Last commit99704b0
Preview URLhttps://dev-montage.wanted.co.kr/99704b0

@Sh031224 Sh031224 merged commit 4bd51c0 into main Apr 8, 2026
6 checks passed
@Sh031224 Sh031224 deleted the fix/sh031224/icon-doc-color branch April 8, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants