Skip to content

fix(wds): fallback-view title 색상이 상속되지 않도록 수정#533

Merged
Sh031224 merged 1 commit intomainfrom
fix/sh031224/fallback-view-title-color
Apr 8, 2026
Merged

fix(wds): fallback-view title 색상이 상속되지 않도록 수정#533
Sh031224 merged 1 commit intomainfrom
fix/sh031224/fallback-view-title-color

Conversation

@Sh031224
Copy link
Copy Markdown
Collaborator

@Sh031224 Sh031224 commented Apr 8, 2026

변경 사항

FallbackView의 title 색상이 상위 요소로부터 상속되던 이슈를 수정했습니다.

  • [data-role='fallback-view-text-title']color: ${theme.semantic.label.normal}을 명시적으로 지정
  • 의도한 디자인 토큰(label.normal)이 항상 적용되도록 보장

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 스타일
    • 폴백 뷰의 텍스트 제목 색상이 업데이트되었습니다.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Sh031224 Sh031224 self-assigned this Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ae685d60-13ae-4537-9c0a-90835fc92a6c

📥 Commits

Reviewing files that changed from the base of the PR and between 391818a and 8f90414.

📒 Files selected for processing (1)
  • packages/wds/src/components/fallback-view/style.ts

Walkthrough

CSS 스타일시트의 fallback-view-text-title 요소 선택자에 색상 속성을 추가하여 테마의 시맨틱 라벨 일반 색상을 명시적으로 지정했습니다.

Changes

Cohort / File(s) Summary
Fallback View 스타일
packages/wds/src/components/fallback-view/style.ts
[data-role='fallback-view-text-title'] 선택자에 color: theme.semantic.label.normal 속성을 추가했습니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 주요 변경 사항을 명확하게 요약하고 있습니다. 'fallback-view title 색상이 상속되지 않도록 수정'이라는 제목은 변경 사항과 정확히 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sh031224/fallback-view-title-color

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sh031224 Sh031224 added this to the 3.4.4 milestone Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

size-limit report 📦

Path Size
wds 2.37 KB (0%)
wds-icon 5 KB (0%)
wds-lottie 83 B (0%)
wds-theme 144 B (0%)
wds-engine 332 B (0%)
wds-nextjs 165 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🚀 Preview

Last commit6381781
Preview URLhttps://dev-montage.wanted.co.kr/6381781

@Sh031224 Sh031224 merged commit b6b41a9 into main Apr 8, 2026
11 checks passed
@Sh031224 Sh031224 deleted the fix/sh031224/fallback-view-title-color branch April 8, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants