Skip to content

[WRP-282] TextField 자동완성 accessibilityIdentifier 추가#457

Merged
knine79 merged 1 commit intomainfrom
feature/WRP-282-accessibility
Apr 8, 2026
Merged

[WRP-282] TextField 자동완성 accessibilityIdentifier 추가#457
knine79 merged 1 commit intomainfrom
feature/WRP-282-accessibility

Conversation

@knine79
Copy link
Copy Markdown
Contributor

@knine79 knine79 commented Apr 7, 2026

UI 테스트 자동화(AXe CLI)에서 온보딩 학교/회사 자동완성 항목을 식별할 수 있도록 accessibilityIdentifier 추가

  • autocomplete_container: 자동완성 컨테이너
  • autocomplete_item_{section}_{item}: 개별 자동완성 항목

Summary by CodeRabbit

릴리스 노트

  • 접근성

    • 자동 완성 UI 요소에 접근성 식별자 추가
  • 다국어 지원

    • 새로운 지역화 문자열 항목 추가
    • 한국어를 포함한 다국어 문자열 지원 강화
    • 지역화 문자열 항목 정렬 최적화

@knine79 knine79 self-assigned this Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65bb2d38-05d2-4b04-86e7-12cfc2ef04de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/WRP-282-accessibility

Comment @coderabbitai help to get the list of available commands and usage tips.

@knine79 knine79 added this to the 3.4.5 milestone Apr 7, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Sources/Montage/Asset/Localizable.xcstrings`:
- Around line 4-31: The PR adds empty Korean localization entries for keys "*"
and "/" and "뒤로 가기" in Localizable.xcstrings while the code references these
symbols (Text("*") used in TextField.swift, TextArea.swift, Select.swift;
Text("/") in PageCounter.swift; String(localized: "뒤로 가기", ...) in
TopNavigation.swift), so either populate the Korean translations for these keys
in the .xcstrings or remove the autogenerated entries from this PR and add them
in a dedicated localization PR; update the .xcstrings so the "value" for
"%@"-style entries and the entries for "*" , "/" and "뒤로 가기" contain the proper
Korean strings (or revert the additions) and ensure the PR description notes the
localization change if you keep them.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb3388b9-b348-4a31-8d84-2daed85b28c7

📥 Commits

Reviewing files that changed from the base of the PR and between 615ffb4 and 3bbe788.

📒 Files selected for processing (2)
  • Sources/Montage/1 Components/3 Selection And Input/TextField.swift
  • Sources/Montage/Asset/Localizable.xcstrings

@github-actions github-actions bot added the in review This issue requires a review. label Apr 7, 2026
@knine79 knine79 marked this pull request as ready for review April 7, 2026 06:29
@knine79 knine79 requested a review from a team as a code owner April 7, 2026 06:29
@knine79 knine79 requested review from agiletalk and jhseo and removed request for a team April 7, 2026 06:29
@github-actions github-actions bot added accepted This issue has been reviewed. and removed in review This issue requires a review. labels Apr 7, 2026
@knine79 knine79 modified the milestones: 3.4.5, 3.4.6 Apr 7, 2026
@knine79 knine79 merged commit 05d2e02 into main Apr 8, 2026
5 checks passed
@knine79 knine79 deleted the feature/WRP-282-accessibility branch April 8, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted This issue has been reviewed. AI Review Completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants