fix(TopNavigation): TrailingContents, LeadingButton contentShape를 고정 패딩으로 변경

[knine79]

개요

• 이슈 링크 : https://wantedlab.atlassian.net/browse/WRP-271

수정사항

• TopNavigation.TrailingContents와 LeadingButton의 contentShape(Rectangle().scale(2))를 contentShape(Rectangle().inset(by: -10))으로 변경
• 2배 스케일링 대신 고정 10pt 패딩으로 터치 영역을 확장하여, 넓은 커스텀 버튼(예: 이력서 상세의 리뷰 버튼)이 인접 버튼과 접근성 프레임이 겹치는 문제 해결

미리보기

N/A (접근성 프레임 변경으로 시각적 차이 없음)

Summary by CodeRabbit

릴리스 노트

• 버그 수정
  • 상단 네비게이션 버튼의 터치 타겟 영역을 개선하여 더 정확한 탭 인식성을 제공합니다.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bc0c7e07-3df0-4c2e-9ce4-bf4da0055da7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/topnavigation-contentshape-padding

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

Sources/Montage/1 Components/6 Navigations/TopNavigation.swift (1)

506-506: -10 인셋 값을 공용 상수로 추출해두는 것을 권장합니다.

동일 매직 넘버가 두 위치에 중복되어 있어, 추후 hit area 조정 시 한쪽만 수정될 위험이 있습니다.

제안 diff

 public struct TopNavigation: View {
+    private static let hitAreaInset: CGFloat = -10
@@
     struct TrailingContents: View {
@@
                     contents[index]()
-                        .contentShape(Rectangle().inset(by: -10)) // 터치영역 확장 (고정 패딩)
+                        .contentShape(Rectangle().inset(by: TopNavigation.hitAreaInset)) // 터치영역 확장 (고정 패딩)
                 }
             }
         }
     }
@@
                 }
-                .contentShape(Rectangle().inset(by: -10)) // 터치영역 확장 (고정 패딩)
+                .contentShape(Rectangle().inset(by: TopNavigation.hitAreaInset)) // 터치영역 확장 (고정 패딩)
             } else {

Also applies to: 563-563

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Sources/Montage/1` Components/6 Navigations/TopNavigation.swift at line 506,
Extract the magic value -10 into a shared constant (e.g., TOUCH_AREA_INSET or
touchAreaInset: CGFloat) defined near the TopNavigation view (file-level private
or static property on TopNavigation) and replace the two occurrences of
.contentShape(Rectangle().inset(by: -10)) with
.contentShape(Rectangle().inset(by: TOUCH_AREA_INSET)); ensure both instances
(the one currently at contentShape with inset and the other occurrence around
line 563) use the same constant so future hit-area adjustments require changing
only that single definition.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Sources/Montage/1` Components/6 Navigations/TopNavigation.swift:
- Line 506: Extract the magic value -10 into a shared constant (e.g.,
TOUCH_AREA_INSET or touchAreaInset: CGFloat) defined near the TopNavigation view
(file-level private or static property on TopNavigation) and replace the two
occurrences of .contentShape(Rectangle().inset(by: -10)) with
.contentShape(Rectangle().inset(by: TOUCH_AREA_INSET)); ensure both instances
(the one currently at contentShape with inset and the other occurrence around
line 563) use the same constant so future hit-area adjustments require changing
only that single definition.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a2d3c9c-3d3b-46d8-9ef4-0b3500e57695

📥 Commits

Reviewing files that changed from the base of the PR and between 615ffb4 and 7e2781b.

📒 Files selected for processing (1)

• Sources/Montage/1 Components/6 Navigations/TopNavigation.swift