fix: Select 드롭다운 화살표 메뉴 열림 시 180도 회전 (PI-82363)#443
Merged
Conversation
WalkthroughSelect.swift 파일에서 드롭다운 메뉴의 open/close 상태에 따라 chevron 아이콘을 회전시키는 시각적 효과를 추가했습니다. menuPresented 상태가 true일 때 180도, false일 때 0도 회전을 적용합니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Sources/Montage/1 Components/3 Selection And Input/Select.swift (1)
391-391: 회전 애니메이션 추가를 고려해 주세요.현재 회전 효과가 즉각적으로 적용되어 상태 변화가 다소 갑작스러울 수 있습니다. 부드러운 UX를 위해 애니메이션을 추가하는 것을 권장합니다.
♻️ 애니메이션 적용 제안
.frame(height: 24) .rotationEffect(.degrees(menuPresented.wrappedValue ? 180 : 0)) + .animation(.easeInOut(duration: 0.2), value: menuPresented.wrappedValue)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Sources/Montage/1` Components/3 Selection And Input/Select.swift at line 391, The rotationEffect on the chevron uses menuPresented.wrappedValue but is abrupt; make the rotation animate by applying SwiftUI animation tied to that state—e.g., attach an .animation modifier (or wrap state changes in withAnimation) using an easing/timing (e.g., .easeInOut) and use the menuPresented value as the animation trigger so the rotation of the view referenced by rotationEffect(.degrees(menuPresented.wrappedValue ? 180 : 0)) transitions smoothly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Sources/Montage/1` Components/3 Selection And Input/Select.swift:
- Line 391: The rotationEffect on the chevron uses menuPresented.wrappedValue
but is abrupt; make the rotation animate by applying SwiftUI animation tied to
that state—e.g., attach an .animation modifier (or wrap state changes in
withAnimation) using an easing/timing (e.g., .easeInOut) and use the
menuPresented value as the animation trigger so the rotation of the view
referenced by rotationEffect(.degrees(menuPresented.wrappedValue ? 180 : 0))
transitions smoothly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dd309340-4d01-4a7e-90cf-768b774bd636
📒 Files selected for processing (1)
Sources/Montage/1 Components/3 Selection And Input/Select.swift
agiletalk
approved these changes
Mar 11, 2026
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
수정 내용
rotationEffect를 추가하여 메뉴가 열려있을 때 180도 회전하도록 수정했습니다.미리보기
해당 없음
Summary by CodeRabbit