Skip to content

fix: Select 드롭다운 화살표 메뉴 열림 시 180도 회전 (PI-82363)#443

Merged
knine79 merged 1 commit intomainfrom
feature/PI-82363
Mar 11, 2026
Merged

fix: Select 드롭다운 화살표 메뉴 열림 시 180도 회전 (PI-82363)#443
knine79 merged 1 commit intomainfrom
feature/PI-82363

Conversation

@knine79
Copy link
Copy Markdown
Contributor

@knine79 knine79 commented Mar 11, 2026

개요

수정 내용

  • Select 컴포넌트의 드롭다운 화살표 아이콘에 rotationEffect를 추가하여 메뉴가 열려있을 때 180도 회전하도록 수정했습니다.

미리보기

해당 없음

Summary by CodeRabbit

  • 새로운 기능
    • 선택 드롭다운 메뉴가 열리고 닫힐 때 체브론 아이콘이 180도 회전하는 시각적 피드백이 추가되었습니다. 메뉴의 열림/닫힘 상태에 따라 아이콘이 동적으로 반응하여 드롭다운의 현재 상태를 시각적으로 확인할 수 있습니다.

@knine79 knine79 requested a review from a team as a code owner March 11, 2026 05:21
@knine79 knine79 requested review from agiletalk and szzang-kr and removed request for a team March 11, 2026 05:22
@knine79 knine79 added the in review This issue requires a review. label Mar 11, 2026
@knine79 knine79 self-assigned this Mar 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 11, 2026

Walkthrough

Select.swift 파일에서 드롭다운 메뉴의 open/close 상태에 따라 chevron 아이콘을 회전시키는 시각적 효과를 추가했습니다. menuPresented 상태가 true일 때 180도, false일 때 0도 회전을 적용합니다.

Changes

Cohort / File(s) Summary
Chevron Icon Rotation
Sources/Montage/1 Components/3 Selection And Input/Select.swift
Added rotationEffect modifier to chevron icon that rotates 180 degrees when menu is presented, 0 degrees otherwise, providing visual feedback for dropdown state.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 변경사항의 핵심을 명확히 설명하고 있습니다. Select 컴포넌트의 드롭다운 화살표가 메뉴 열림 시 180도 회전하는 기능 추가를 간결하고 구체적으로 표현했습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/PI-82363

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Sources/Montage/1 Components/3 Selection And Input/Select.swift (1)

391-391: 회전 애니메이션 추가를 고려해 주세요.

현재 회전 효과가 즉각적으로 적용되어 상태 변화가 다소 갑작스러울 수 있습니다. 부드러운 UX를 위해 애니메이션을 추가하는 것을 권장합니다.

♻️ 애니메이션 적용 제안
                     .frame(height: 24)
                     .rotationEffect(.degrees(menuPresented.wrappedValue ? 180 : 0))
+                    .animation(.easeInOut(duration: 0.2), value: menuPresented.wrappedValue)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Sources/Montage/1` Components/3 Selection And Input/Select.swift at line 391,
The rotationEffect on the chevron uses menuPresented.wrappedValue but is abrupt;
make the rotation animate by applying SwiftUI animation tied to that state—e.g.,
attach an .animation modifier (or wrap state changes in withAnimation) using an
easing/timing (e.g., .easeInOut) and use the menuPresented value as the
animation trigger so the rotation of the view referenced by
rotationEffect(.degrees(menuPresented.wrappedValue ? 180 : 0)) transitions
smoothly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Sources/Montage/1` Components/3 Selection And Input/Select.swift:
- Line 391: The rotationEffect on the chevron uses menuPresented.wrappedValue
but is abrupt; make the rotation animate by applying SwiftUI animation tied to
that state—e.g., attach an .animation modifier (or wrap state changes in
withAnimation) using an easing/timing (e.g., .easeInOut) and use the
menuPresented value as the animation trigger so the rotation of the view
referenced by rotationEffect(.degrees(menuPresented.wrappedValue ? 180 : 0))
transitions smoothly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd309340-4d01-4a7e-90cf-768b774bd636

📥 Commits

Reviewing files that changed from the base of the PR and between 4610daa and ffc55d1.

📒 Files selected for processing (1)
  • Sources/Montage/1 Components/3 Selection And Input/Select.swift

@knine79 knine79 added this to the 3.3.2 milestone Mar 11, 2026
@github-actions github-actions bot added accepted This issue has been reviewed. and removed in review This issue requires a review. labels Mar 11, 2026
@knine79 knine79 merged commit 06f0dba into main Mar 11, 2026
5 checks passed
@knine79 knine79 deleted the feature/PI-82363 branch March 11, 2026 06:18
@knine79 knine79 modified the milestones: 3.3.2.1, 3.3.2 Mar 12, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted This issue has been reviewed. AI Review Completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants