fix the issue in plot_bvec #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #337 +/- ##
===========================================
- Coverage 66.40% 65.96% -0.45%
===========================================
Files 29 29
Lines 17992 17774 -218
===========================================
- Hits 11948 11724 -224
- Misses 6044 6050 +6
Continue to review full report at Codecov.
|
|
For some reason I cannot automatically merge - maybe it's a temporary issue with GitHub. Can you merge develop in your branch? I'll merge then. |
|
Dear Giovanni Pizzi: As you suggested, I merged the develop in W90 in my branch. Sincerely, Hyungjun Lee |
recent updates in W90
giovannipizzi
approved these changes
Jul 17, 2020
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
fix the issue in plot_bvec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all:
This commit fixes the issue in writing *.bvec file which is necessary for the evaluation of velocity matrix elements in EPW.
Previously, the writing of bvec file is triggered by the input flags which are not directly related to it.
Additionally, I removed one of two open statements and increased the number of significant digits in *.bvec file so that it matches those from kmesh.pl .
On behalf of the EPW developers' team,
Hyungjun Lee