forked from xiaoxinglai/excel2pdf
-
Notifications
You must be signed in to change notification settings - Fork 0
test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wangwangxf
wants to merge
10
commits into
legacy
Choose a base branch
from
master
base: legacy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
錯誤修正(Bug fix) 1.Excel 的最後一行不會處理 2.若有 null cell(程式產生的 Excel),則排版換行會出錯 改進(Enhance) 1.可設定紙張大小,若單張 Excel,則依據版面設定中的紙張大小作為 PDF 輸出大小 2.允許設定是否自動產生頁碼 3.輸出欄位寬度與 Excel 同比例 4.納入Cell 內定義的格式(會計格式等) 5.表格置中(這個應該設計得更有彈性) 6.只要將測試Excel檔放入 src/test/resources 下,單元測試會自動納入,測試檔也放入 Git 以方便各類型 Excel 可加入測試 7.POI from 3.9 to 3.15 8.iText from 5.4.4 to 5.5.13
Reviewer's GuideThis PR restructures the Maven build configuration with rich metadata and profiles, enriches the README with usage examples, modularizes the excel-to-PDF conversion logic into dedicated utility packages, and introduces an annotation-driven data model accompanied by an updated test harness. Class Diagram for Data Model (LandTaxDeclarationVO) and Annotation (@CellVal)classDiagram
class LandTaxDeclarationVO {
<<VO>>
-String taxpayerID
-String taxPeriod
-String newDate
-String accountCodeName
-BigDecimal oneOneValue
-BigDecimal oneTwoValue
-String oneSixValue
-BigDecimal oneSevenValue
-BigDecimal oneNineValue
-BigDecimal oneTenValue
-BigDecimal oneElevenValue
+String getTaxpayerID()
+void setTaxpayerID(String)
+String getTaxPeriod()
+void setTaxPeriod(String)
// ... (other getters and setters)
}
LandTaxDeclarationVO ..> CellVal : fields annotated by
class CellVal {
<<Annotation>>
+int row()
+int col()
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
The description of the PR:
Other information:
Summary by Sourcery
Enhance Maven configuration, refactor project structure, and introduce an annotation-driven Excel-to-PDF conversion workflow with improved documentation and tests
New Features:
Enhancements:
Build:
Documentation:
Tests: