Add UT for 400 error in connector APIs

Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam · Sep 4, 2024 · 610f0d8 · 610f0d8
1 parent a2e1de1
commit 610f0d8
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 4 deletions.
diff --git a/server/routes/__tests__/connector_router.test.ts b/server/routes/__tests__/connector_router.test.ts
@@ -6,20 +6,26 @@
 import { ResponseObject } from '@hapi/hapi';
 
 import { Router } from '../../../../../src/core/server/http/router';
+import { OpenSearchClient } from '../../../../../src/core/server';
 import { triggerHandler, createDataSourceEnhancedRouter } from '../router.mock';
 import { httpServerMock } from '../../../../../src/core/server/http/http_server.mocks';
 import { loggerMock } from '../../../../../src/core/server/logging/logger.mock';
 import { connectorRouter } from '../connector_router';
 import { CONNECTOR_API_ENDPOINT, INTERNAL_CONNECTOR_API_ENDPOINT } from '../constants';
 import { ConnectorService } from '../../services/connector_service';
+import { Boom } from '@hapi/boom';
 
-const setupRouter = () => {
+const setupRouter = ({
+  getClient,
+}: {
+  getClient?: (dataSourceId: string) => Promise<Pick<OpenSearchClient, 'transport'>>;
+} = {}) => {
   const mockedLogger = loggerMock.create();
   const {
     router,
     dataSourceTransportMock,
     getLatestCurrentUserTransport,
-  } = createDataSourceEnhancedRouter(mockedLogger);
+  } = createDataSourceEnhancedRouter(mockedLogger, getClient);
 
   connectorRouter(router);
   return {
@@ -85,6 +91,20 @@ describe('connector routers', () => {
         size: 10000,
       });
     });
+
+    it('should throw 400 error when failed to get data source', async () => {
+      const getClientMock = jest.fn().mockRejectedValue(new Error('Unknown error'));
+      const { router } = setupRouter({ getClient: getClientMock });
+
+      const result = (await triggerGetAllConnectors(router, 'foo')) as Boom;
+      expect(result.output.payload).toMatchInlineSnapshot(`
+        Object {
+          "error": "Bad Request",
+          "message": "Unknown error",
+          "statusCode": 400,
+        }
+      `);
+    });
   });
 
   describe('get all internal connector', () => {
@@ -113,5 +133,19 @@ describe('connector routers', () => {
         size: 10000,
       });
     });
+
+    it('should throw 400 error when failed to get data source', async () => {
+      const getClientMock = jest.fn().mockRejectedValue(new Error('Unknown error'));
+      const { router } = setupRouter({ getClient: getClientMock });
+
+      const result = (await triggerGetAllInternalConnectors(router, 'foo')) as Boom;
+      expect(result.output.payload).toMatchInlineSnapshot(`
+        Object {
+          "error": "Bad Request",
+          "message": "Unknown error",
+          "statusCode": 400,
+        }
+      `);
+    });
   });
 });
diff --git a/server/routes/router.mock.ts b/server/routes/router.mock.ts
@@ -126,7 +126,10 @@ export const triggerHandler = async (
   return await findRoute?.handler(options.req, new MockResponseToolkit());
 };
 
-export const createDataSourceEnhancedRouter = (logger: Logger) => {
+export const createDataSourceEnhancedRouter = (
+  logger: Logger,
+  getClient?: (dataSourceId: string) => Promise<Pick<OpenSearchClient, 'transport'>>
+) => {
   const dataSourceTransportMock = {};
   let latestCurrentUserTransport: OpenSearchClient['transport'];
   const router = new Router('', logger, (fn) => (req, res) => {
@@ -138,7 +141,9 @@ export const createDataSourceEnhancedRouter = (logger: Logger) => {
         core,
         dataSource: {
           opensearch: {
-            getClient: async (_dataSourceId: string) => ({ transport: dataSourceTransportMock }),
+            getClient:
+              getClient ??
+              (async (_dataSourceId: string) => ({ transport: dataSourceTransportMock })),
           },
         },
       },