Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the sign.ps1 script by removing redundant path specifications and parameters from various dotnet commands. This streamlines the script and improves clarity by relying on the default current directory.
- Removed explicit .\src\ paths from dotnet clean, restore, build, and pack commands.
- Updated Get-ChildItem command to search the current directory recursively.
Comments suppressed due to low confidence (2)
sign.ps1:18
- Verify that removing the explicit .\src\ path argument is appropriate for all execution contexts, ensuring dotnet clean operates in the intended directory.
dotnet clean -c Release -tl
sign.ps1:21
- [nitpick] Consider explicitly specifying a path (e.g., '-Path .') to clearly indicate that the recursive search should start from the current directory.
Get-ChildItem -Recurse Wangkanai.*.dll | where { $_.Directory -like "*Release*" } | foreach {
…alse in Directory.Build.props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the
sign.ps1script by simplifying thedotnetcommands and removing redundant path specifications. These changes streamline the script and make it more concise.Script simplifications:
.\srcThis pull request makes improvements to thesign.ps1script by simplifying thedotnet` commands and removing redundant path specifications. These changes streamline the script and make it more concise.Script simplifications:
path specification from
dotnet clean,dotnet restore,dotnet build, anddotnet packcommands, as the commands now operate in the current directory by default. ([sign.ps1L18-R25](https://github.com/wangkanai/caster/pull/18/files#diff-863a5e226c030bf68a67b477c7cec4fa67d61e98fe511b2825ac55cdab14e612L18-R25))Get-ChildItemcommand to remove the.\srcThis pull request makes improvements to thesign.ps1script by simplifying thedotnet` commands and removing redundant path specifications. These changes streamline the script and make it more concise.Script simplifications:
.\srcThis pull request makes improvements to thesign.ps1script by simplifying thedotnet` commands and removing redundant path specifications. These changes streamline the script and make it more concise.Script simplifications:
path specification from
dotnet clean,dotnet restore,dotnet build, anddotnet packcommands, as the commands now operate in the current directory by default. ([sign.ps1L18-R25](https://github.com/wangkanai/caster/pull/18/files#diff-863a5e226c030bf68a67b477c7cec4fa67d61e98fe511b2825ac55cdab14e612L18-R25))path and start the recursive search from the current directory, improving clarity and consistency. (
[sign.ps1L18-R25](https://github.com/wangkanai/caster/pull/18/files#diff-863a5e226c030bf68a67b477c7cec4fa67d61e98fe511b2825ac55cdab14e612L18-R25))