Skip to content

Simplify sign.ps1 by removing redundant paths and parameters.#18

Merged
wangkanai merged 7 commits intomainfrom
sign
Jun 13, 2025
Merged

Simplify sign.ps1 by removing redundant paths and parameters.#18
wangkanai merged 7 commits intomainfrom
sign

Conversation

@wangkanai
Copy link
Owner

This pull request makes improvements to the sign.ps1 script by simplifying the dotnet commands and removing redundant path specifications. These changes streamline the script and make it more concise.

Script simplifications:

  • Removed unnecessary .\srcThis pull request makes improvements to the sign.ps1script by simplifying thedotnet` commands and removing redundant path specifications. These changes streamline the script and make it more concise.

Script simplifications:

path specification from dotnet clean, dotnet restore, dotnet build, and dotnet pack commands, as the commands now operate in the current directory by default. ([sign.ps1L18-R25](https://github.com/wangkanai/caster/pull/18/files#diff-863a5e226c030bf68a67b477c7cec4fa67d61e98fe511b2825ac55cdab14e612L18-R25))

  • Adjusted the Get-ChildItem command to remove the .\srcThis pull request makes improvements to the sign.ps1script by simplifying thedotnet` commands and removing redundant path specifications. These changes streamline the script and make it more concise.

Script simplifications:

  • Removed unnecessary .\srcThis pull request makes improvements to the sign.ps1script by simplifying thedotnet` commands and removing redundant path specifications. These changes streamline the script and make it more concise.

Script simplifications:

path specification from dotnet clean, dotnet restore, dotnet build, and dotnet pack commands, as the commands now operate in the current directory by default. ([sign.ps1L18-R25](https://github.com/wangkanai/caster/pull/18/files#diff-863a5e226c030bf68a67b477c7cec4fa67d61e98fe511b2825ac55cdab14e612L18-R25))
path and start the recursive search from the current directory, improving clarity and consistency. ([sign.ps1L18-R25](https://github.com/wangkanai/caster/pull/18/files#diff-863a5e226c030bf68a67b477c7cec4fa67d61e98fe511b2825ac55cdab14e612L18-R25))

@wangkanai wangkanai self-assigned this Jun 13, 2025
Copilot AI review requested due to automatic review settings June 13, 2025 06:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the sign.ps1 script by removing redundant path specifications and parameters from various dotnet commands. This streamlines the script and improves clarity by relying on the default current directory.

  • Removed explicit .\src\ paths from dotnet clean, restore, build, and pack commands.
  • Updated Get-ChildItem command to search the current directory recursively.
Comments suppressed due to low confidence (2)

sign.ps1:18

  • Verify that removing the explicit .\src\ path argument is appropriate for all execution contexts, ensuring dotnet clean operates in the intended directory.
dotnet clean    -c Release -tl

sign.ps1:21

  • [nitpick] Consider explicitly specifying a path (e.g., '-Path .') to clearly indicate that the recursive search should start from the current directory.
Get-ChildItem   -Recurse Wangkanai.*.dll | where { $_.Directory -like "*Release*" } | foreach {

@wangkanai wangkanai added this to Caster Jun 13, 2025
@wangkanai wangkanai moved this to In progress in Caster Jun 13, 2025
@wangkanai wangkanai added this to the 0.0.0-alpha2 milestone Jun 13, 2025
@wangkanai wangkanai merged commit 84ac385 into main Jun 13, 2025
1 check passed
@wangkanai wangkanai deleted the sign branch June 13, 2025 10:14
@github-project-automation github-project-automation bot moved this from In progress to Done in Caster Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant