Skip to content

Update sign.ps1 script: rename parameters, refine paths, and adjust…#16

Merged
wangkanai merged 1 commit intomainfrom
sign
Jun 13, 2025
Merged

Update sign.ps1 script: rename parameters, refine paths, and adjust…#16
wangkanai merged 1 commit intomainfrom
sign

Conversation

@wangkanai
Copy link
Owner

This pull request updates the sign.ps1 script to improve clarity, align with updated naming conventions, and enhance functionality. The most important changes include renaming parameters and variables, refining directory-specific operations, and updating conditional logic for better readability and accuracy.

Parameter and variable renaming:

  • Renamed the dryrun parameter to publish and inverted its logic to improve clarity. [1] [2]
  • Renamed the certicate variable to name for consistency and correctness. [1] [2]

Directory-specific operations:

  • Updated dotnet commands (clean, restore, build, and pack) to explicitly target the .\srcThis pull request updates the sign.ps1` script to improve clarity, align with updated naming conventions, and enhance functionality. The most important changes include renaming parameters and variables, refining directory-specific operations, and updating conditional logic for better readability and accuracy.

Parameter and variable renaming:

  • Renamed the dryrun parameter to publish and inverted its logic to improve clarity. [1] [2]
  • Renamed the certicate variable to name for consistency and correctness. [1] [2]

Directory-specific operations:

directory, ensuring operations are scoped correctly.

Conditional logic updates:

  • Modified the condition to check for !$publish instead of $dryrun and updated the corresponding message to "Skip update: System" for better readability.

@wangkanai wangkanai self-assigned this Jun 13, 2025
Copilot AI review requested due to automatic review settings June 13, 2025 05:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the sign.ps1 script to improve clarity and functionality by renaming parameters and variables, refining directory-specific operations, and updating conditional logic.

  • Renamed the "dryrun" parameter to "publish" with inverted logic
  • Renamed the "certicate" variable to "name" for consistency
  • Adjusted dotnet command paths and signing logic to target the correct source directory
Comments suppressed due to low confidence (1)

sign.ps1:9

  • The output message still references the outdated variable '$certicate'. Update this to '$name' to ensure consistency with the renamed parameter and variable.
Write-Host "NuGet Certificate: $certicate"  -ForegroundColor Magenta

@wangkanai wangkanai added the feature New feature plan label Jun 13, 2025
@wangkanai wangkanai added this to Caster Jun 13, 2025
@wangkanai wangkanai moved this to In progress in Caster Jun 13, 2025
@wangkanai wangkanai added this to the 0.0.0-alpha2 milestone Jun 13, 2025
@wangkanai wangkanai merged commit b3b1c82 into main Jun 13, 2025
1 check passed
@wangkanai wangkanai deleted the sign branch June 13, 2025 05:46
@github-project-automation github-project-automation bot moved this from In progress to Done in Caster Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature plan

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant