Conversation
… condition logic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sign.ps1 script to improve clarity and functionality by renaming parameters and variables, refining directory-specific operations, and updating conditional logic.
- Renamed the "dryrun" parameter to "publish" with inverted logic
- Renamed the "certicate" variable to "name" for consistency
- Adjusted dotnet command paths and signing logic to target the correct source directory
Comments suppressed due to low confidence (1)
sign.ps1:9
- The output message still references the outdated variable '$certicate'. Update this to '$name' to ensure consistency with the renamed parameter and variable.
Write-Host "NuGet Certificate: $certicate" -ForegroundColor Magenta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
sign.ps1script to improve clarity, align with updated naming conventions, and enhance functionality. The most important changes include renaming parameters and variables, refining directory-specific operations, and updating conditional logic for better readability and accuracy.Parameter and variable renaming:
dryrunparameter topublishand inverted its logic to improve clarity. [1] [2]certicatevariable tonamefor consistency and correctness. [1] [2]Directory-specific operations:
dotnetcommands (clean,restore,build, andpack) to explicitly target the.\srcThis pull request updates thesign.ps1` script to improve clarity, align with updated naming conventions, and enhance functionality. The most important changes include renaming parameters and variables, refining directory-specific operations, and updating conditional logic for better readability and accuracy.Parameter and variable renaming:
dryrunparameter topublishand inverted its logic to improve clarity. [1] [2]certicatevariable tonamefor consistency and correctness. [1] [2]Directory-specific operations:
directory, ensuring operations are scoped correctly.
Conditional logic updates:
!$publishinstead of$dryrunand updated the corresponding message to "Skip update: System" for better readability.