Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft(react): React sketch #51

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

draft(react): React sketch #51

wants to merge 3 commits into from

Conversation

chrisdhanaraj
Copy link
Contributor

Hello! Okay sorry for the delay, some life things prevented me from getting to this.

General Disclaimers: Proof of concept, not production code, etcetec. This draft is to show how things could get connected in

Notable Things:

  • Vite integration is done through the existing express server - this could probably be used for any SPA integration that uses Vite
  • I added a quick sketch of a api/profiles/characters for the front-end to ping. There were a couple of small concurrency issues with the original code I cleaned up here - might be good to check out for these elsewhere in the codebase
  • Standard Tailwind integration isn't quite working yet, so I've dropped the Tailwind CDN in for now; I'll fix this in a production version
  • You should be able to pull this down locally and run it, however the deployed version is not setup yet

Copy link
Contributor

@Quzzar Quzzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great proof of concept.
I did have some issues running the branch locally on windows, had to change the npm dev script to NODE_ENV=development concurrently \"nodemon app.js\" \"vite\".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants