fix(artifacts): raise for invalid artifact names

[tonyyli-wandb]

Description

• WB-21718

Validates Artifact names on instantiation, raising a ValueError if the name is expected to be invalid (i.e. the artifact cannot be logged).

• I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

[tonyyli-wandb]

• fix(artifacts): raise for invalid artifact names #8773 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tonyyli-wandb and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (e7c06b8) to head (1db7461).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8773      +/-   ##
==========================================
- Coverage   70.34%   70.34%   -0.01%     
==========================================
  Files         547      547              
  Lines       58097    58107      +10     
==========================================
+ Hits        40868    40873       +5     
- Misses      16565    16574       +9     
+ Partials      664      660       -4     

Flag	Coverage Δ
func	36.95% <64.28%> (+<0.01%)	⬆️
system	54.57% <100.00%> (-0.04%)	⬇️
unit	51.25% <78.57%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
wandb/apis/public/artifacts.py	93.39% <100.00%> (+0.02%)	⬆️
wandb/sdk/artifacts/_validators.py	100.00% <100.00%> (ø)
wandb/sdk/artifacts/artifact.py	88.74% <100.00%> (+0.11%)	⬆️

... and 22 files with indirect coverage changes

[ibindlish]

lgtm!

(non-blocking question): The ArtifactCollection class also has a name setter:

wandb/wandb/apis/public/artifacts.py

Lines 539 to 540 in 8a345e6

	def name(self, name: List[str]) -> None:
	self._name = name

I think we can use the same validator to check the artifact name there since the validator for artifact.name is also for sequence name. Wdyt?

[tonyyli-wandb]

(non-blocking question): The ArtifactCollection class also has a name setter:

wandb/wandb/apis/public/artifacts.py

Lines 539 to 540 in 8a345e6

	def name(self, name: List[str]) -> None:
	self._name = name

I think we can use the same validator to check the artifact name there since the validator for artifact.name is also for sequence name. Wdyt?

Good point -- I think so too. Thanks for the catch!