use chmod before listen instead of fchmod, related to boazsegev…

…#136
waltjones · Jan 8, 2023 · a89d156 · a89d156
1 parent c90a33e
commit a89d156
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
+#### Change log v.0.7.53 (expected: 2023-01-10)
+
+**Fix**: Fixes Unix socket permission limitations, so unix sockets are not limited to the owner of the process. Credit to Patrik Rak (@raxoft) for opening issue #136.
 
 #### Change log v.0.7.52 (2022-12-10)
 

diff --git a/ext/iodine/fio.c b/ext/iodine/fio.c
@@ -3203,13 +3203,14 @@ static intptr_t fio_unix_socket(const char *address, uint8_t server) {
       close(fd);
       return -1;
     }
+    /* chmod for foreign connections... if possible */
+    if(chmod(addr.sun_path, 0x1FF))
+      FIO_LOG_WARNING("chmod failed for %s (%d: %s)", address, errno, strerror(errno));
     if (listen(fd, SOMAXCONN) < 0) {
       // perror("couldn't start listening to unix socket");
       close(fd);
       return -1;
     }
-    /* chmod for foreign connections */
-    fchmod(fd, 0777);
   } else {
     if (connect(fd, (struct sockaddr *)&addr, sizeof(addr)) == -1 &&
         errno != EINPROGRESS) {

diff --git a/lib/iodine/version.rb b/lib/iodine/version.rb
@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '0.7.52'.freeze
+  VERSION = '0.7.53'.freeze
 end