Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAL-199 - Enhance error handling in waltid library #762

Merged
merged 34 commits into from
Sep 25, 2024
Merged

WAL-199 - Enhance error handling in waltid library #762

merged 34 commits into from
Sep 25, 2024

Conversation

SuperBatata
Copy link
Contributor

Description

Provide a clear and concise description of the changes made in this pull request.

Fixes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SuperBatata
feat : added common module for waltid-libraries
cbaa402
@SuperBatata
fix : removed unnecessary library-common code
88450ed
@SuperBatata
feat : added CryptoExceptions class
b533069
@SuperBatata
feat : added dependencies
7cb412f
@SuperBatata
dep : added library common to crypto
45ef960
@SuperBatata
feat : created cryptoExceptions
adc5461
@SuperBatata
fix : added custom exceptions to KeyManager.kt
3153a57
@SuperBatata
feat : create custom exception for crypto
6348291
@SuperBatata
update gradle file
6c4a5e0
@SuperBatata
fix : switch to multiplatform in library commons
5940909
@SuperBatata
feat : added library common dependencies
82936a9
@SuperBatata
feat : added support to CryptoExceptions in statuspage
af365da
@SuperBatata
feat : moved to commonMain
3716b71
@SuperBatata
fix :added missing library commons dependency in jvmMain
10b301e
@SuperBatata
ci: added waltid-libraries to dockerfiles
599df67
@SuperBatata
fix:removed library-commons from jvm
13ddf97
@SuperBatata
fix: fixed dockerfiles missing library-commons
65ce461
@cpatsonakis cpatsonakis marked this pull request as ready for review September 20, 2024 08:54
@cpatsonakis cpatsonakis marked this pull request as draft September 20, 2024 09:23
@SuperBatata SuperBatata self-assigned this Sep 22, 2024
@SuperBatata SuperBatata marked this pull request as ready for review September 23, 2024 08:05
mikeplotean
mikeplotean previously approved these changes Sep 23, 2024
View reviewed changes
...ibraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/oci/OCIKeyRestApi.kt Outdated Show resolved Hide resolved
...ibraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/oci/OCIKeyRestApi.kt Outdated Show resolved Hide resolved
waltid-libraries/waltid-library-commons/build.gradle.kts Outdated Show resolved Hide resolved
...ibraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/oci/OCIKeyRestApi.kt Outdated Show resolved Hide resolved
...ibraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/oci/OCIKeyRestApi.kt Outdated Show resolved Hide resolved
waltid-libraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/tse/TSEKey.kt Outdated Show resolved Hide resolved
waltid-libraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/tse/TSEKey.kt Outdated Show resolved Hide resolved
waltid-libraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/tse/TSEKey.kt Outdated Show resolved Hide resolved
waltid-libraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/tse/TSEKey.kt Outdated Show resolved Hide resolved
waltid-libraries/crypto/waltid-crypto/src/commonMain/kotlin/id/walt/crypto/keys/tse/TSEKey.kt Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SuperBatata SuperBatata merged commit 950549b into main Sep 25, 2024
4 checks passed
@SuperBatata SuperBatata deleted the feat/error-handling-library branch September 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeplotean mikeplotean mikeplotean approved these changes

@waltkb waltkb Awaiting requested review from waltkb

@cpatsonakis cpatsonakis Awaiting requested review from cpatsonakis

Assignees

@SuperBatata SuperBatata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperBatata @cpatsonakis @mikeplotean