General Bug Fixes/Additons

[walmat]

/fixes #88

Encapsulated is a bit of work that needs to be merged to master and rebased onto the parsing branch.

You can view the full list of items on the issue (some of them I've decided to wait until a later date to implement).

This shouldn't be merged just yet until I figure out how to iron out the bugs with the captcha windows fixed in recent commits

• fix build / add tests

[pr1sm]

Nice job on the Tests!

Just a couple of small things to fix

[pr1sm]

Bumping this since I don't think it's been resolved yet.
https://github.com/walmat/nebula/pull/96/files#r226848357

[pr1sm]

Coverage looks great too! 💯

[pr1sm]

Just a couple more changes, then I think this will be good to go

[pr1sm]

This should go inside the edits object, not inside change itself. This is probably why the tests are all failing.

[walmat]

any tips?

if (action.value) {
            change = {
              edits: {
                ...state.edits,
                errors: Object.assign({}, state.edits.errors, action.errors),
                product: {
                  raw: action.value,
                },
              },
            };
            if (!action.value || !action.value.startsWith('http')) {
              break;
            }
            const URL = parseURL(action.value);
            if (!URL || !URL.path) {
              break;
            }
            const site = getAllSites().filter(s => s.value.split('/')[2] === URL.host);
            if (site.length === 0) {
              break;
            }
            console.log(change);
            change = {
              ...change,
              edits: {
                ...change.edits,
                site: {
                  url: site[0].value,
                  name: site[0].label,
                },
                username: null,
                password: null,
              },
            };
          } else {
            change = {
              edits: {
                ...state.edits,
                errors: Object.assign({}, state.edits.errors, action.errors),
                product: initialTaskStates.edit.product,
              },
            };
          }

[pr1sm]

Is there a need for the else case at the end? If we don't have a value passed with the action, there should be no change, right?

[walmat]

Idk I was working backwards and comparing it to when it worked. Seems to be a bug when edits.product === null

[pr1sm]

This line is also redundant since at this point, change is only an object that contains an edits object, which we explicitly redefine in the line below.

[pr1sm]

I think this is good to go!

[pr1sm]

merging...