-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special Parser Restock Mode #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
added
type:bug
Something isn't working
area:task-runner
Related to Nebula's Task Runner package
priority:urgent
Issues that need to be solved right away
focus:checkout
things involving site checkout (for task runner
focus:monitor
things involving site monitoring
labels
May 10, 2019
walmat
commented
May 10, 2019
packages/task-runner/src/shopify/classes/utils/generateVariants.js
Outdated
Show resolved
Hide resolved
pr1sm
reviewed
May 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass
packages/task-runner/src/shopify/classes/utils/generateVariants.js
Outdated
Show resolved
Hide resolved
* version bump * auth screen resized * Discord RPC (#421) * added discord RPC * added discord RPC * added rpc to update every ~15s in app level * added initial set activity * Obfuscate Source Code (#428) * Add javascript-obfuscator package to task-runner This commit adds the javascript-obfuscator as a dev dependency to the task-runner package so the built output can be obfuscated. * Add Obfuscation to Build Pipeline This commit modifies the task-runner package.json to add obfucation to the build pipeline. The build script is updated to run two sub commands: build:babel and build:obfuscate. The main export file of the package is changed to point to the obfuscated code instead of the built code. Obfuscation options are added to a separate config file so the cli command remains clean. * Add Task Runner Built package This commit adds a new packages that will contain the built, obfuscated code of the task-runner. This package functions exactly the same as the task-runner package, but is safe to include in built packages since no unobfuscated source is contained in it. This package is meant purely as a proxy and no source code nor development should occur here. The task-runner package is updated to change the obfuscated output to this package. The frontend can then depend on this package so the packed app will contain only obfuscated task-runner code. * Switch to use task-runner-built package This commit updates the frontend project to rely on the task-runner-built package. This allows the packed source to include the obfuscated code instead of the full source code. * Obfuscate lib folder This commit updates the frontend package to obfuscate the lib folder. The javascript obfuscator is used for all files in the lib folder and the obfuscated code is moved to a dist/ folder. The main file is updated to use the obfuscated code and the build script is updated to obfuscate code as well as bundle the react side. NOTE: When running in dev mode, the unobfuscated version is used. * Update Electron Builder Config This commit updates the electron builder config to export the `dist/` folder instead of the `lib/` folder. This allows the packed app to run properly. * Add empty lint script This commit adds a missing empty lint script to the task-runner-built package. Linting is not needed in this package since it only contains obfuscated code, but the top level lint script will still attempt to run the lint script in this package. * Fix State Discrepancies (#425) * state discrepencies * rm console log * rm console log * fixed remove all discrepancy * fix test * Colored Log Output Messages (#426) * added colored log messages, and reverted restock loop back due to multiple checkout session being needed * fix tests * pr changes * version 1.0.0 * update rpc file * Captcha Sessions (#430) * captcha session updates * split sessions now managed between YT and captcha pairs * added insecure content on cap win * Apply suggestions from code review Change to camelcase `inUse` and rm some unnecessary code * pr changes * rm dist folder, whoops... * Implement Custom Shopify (#427) * added parse access token * reduced wait time in polling for shipping rates * fixed fsr * added creatable select for site * finished custom shopify impl. * fix some tests * added edit row custom shopify support * test cases fixed * prevent extraneous log messages from showing up * code cleanup + destructuring * lint fix * small changes * some small changes/optimizations * variant matching fixed * default option chosen * added srr custom shopify support * update channel * colored log fixes, + sass compilation
pr1sm
reviewed
May 10, 2019
pr1sm
approved these changes
May 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual Checks pass! 👍
merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:task-runner
Related to Nebula's Task Runner package
focus:checkout
things involving site checkout (for task runner
focus:monitor
things involving site monitoring
priority:urgent
Issues that need to be solved right away
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Special Parser Restock Mode
about: This PR implements a way for special parsers to be able to monitor for restocks
Changes
Checks
fixes #417