Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles SASS Rewrite Follow-Up #372

Merged
merged 6 commits into from
Mar 4, 2019
Merged

Profiles SASS Rewrite Follow-Up #372

merged 6 commits into from
Mar 4, 2019

Conversation

walmat
Copy link
Owner

@walmat walmat commented Feb 27, 2019

name: Profiles SASS Rewrite Follow-Up
about: This PR implements some underlying changes that needed to be made after the issue #335

Changes

  • Split load profile into new file
    • Includes splitting testing into new file
  • Moved headers into respective sections

Checks

  • CI passes
  • Coverage (<2%∆)
  • Manual Checks
    • Normal app performance (tests should cover this)
    • The almighty Srinu's approval <3

fixes #340

@walmat walmat added area:frontend Related to Nebula's Frontend Electron app type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product focus:layout things involving UI layout changes (for frontend) priority:low Issues that are low priority don't need to be solved right away labels Feb 27, 2019
@walmat walmat added this to the Beta 7 Release milestone Feb 27, 2019
@walmat walmat self-assigned this Feb 27, 2019
@walmat walmat requested a review from pr1sm February 27, 2019 08:26
pr1sm
pr1sm previously requested changes Feb 28, 2019
View reviewed changes
Copy link
Collaborator

@pr1sm pr1sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the split out of LoadProfile!

Just one small change

packages/frontend/src/profiles/locationFields.jsx Outdated Show resolved Hide resolved
@walmat walmat requested a review from pr1sm February 28, 2019 20:17
pr1sm
pr1sm approved these changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@pr1sm pr1sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@walmat
Copy link
Owner Author

walmat commented Mar 4, 2019

merging...

@walmat walmat merged commit 9f13116 into b1.0.0-beta.6.1 Mar 4, 2019
@walmat walmat deleted the issue_340 branch March 4, 2019 00:53
@pr1sm pr1sm modified the milestones: Beta 7 Release, Beta 6.1 Release Mar 4, 2019
@pr1sm pr1sm mentioned this pull request Mar 5, 2019
Closed
walmat added a commit that referenced this pull request Mar 14, 2019
@walmat
Profiles SASS Rewrite Follow-Up (#372)
64723c8 
* initial profiles sass rewrite follow up

* split loadProfile testing into new file

* fixed lint

* pr changes

* pr changes

* pr changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr1sm pr1sm pr1sm approved these changes

Assignees

@walmat walmat

Labels
area:frontend Related to Nebula's Frontend Electron app focus:layout things involving UI layout changes (for frontend) priority:low Issues that are low priority don't need to be solved right away type:tech-debt Issues related to adjusting underlying implementation details without affecting the end product
Projects
None yet
Milestone
Beta 6.1 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@walmat @pr1sm