Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Basic Captcha Page Functionality #253

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Fix Basic Captcha Page Functionality #253

merged 4 commits into from
Jan 17, 2019

Commits on Jan 15, 2019

  1. Handle Captcha State

    This commit adds a missing handler for the captcha state. This uses the checkouts handle request captcha method to request a captcha and wait for the token. The handler has also been updated to include error checking.
    pr1sm committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    e41d909 View commit details
    Browse the repository at this point in the history
  2. Use Protocol Interceptors to Load Captcha Page

    This commit adds a protocol interceptor to load our captcha html instead of the regular html for other sites.
    
    This commit also updates the captcha server middleware stack to better handle loading assets such as images/styling/js while still redirecting everything else to the captcha html page.
    
    Issue: #204
    pr1sm committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    774781c View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Add Temporary Workaround for Unhandled Size Option Formats

    Some sites include unsupported size option values, which affects our variant group matching. This commit adds a temporary workaround until the actual issue (#239) is addressed.
    
    Additionally, a linter error is fixed, some unnecessary log statements are removed, and another log statement is adjusted to only display relevant information.
    pr1sm committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    9e852ea View commit details
    Browse the repository at this point in the history
  2. Fix Various Captcha Related Bugs

    This commit addresses some (not all!) captcha related bugs:
    - Captcha Window Reloads are now handled properly
    - Redundant Captcha Reset calls are removed
    - Captcha Windows don't get reset in the middle of harvesting
    - Attempting to add >5 captcha windows no longer crashes the frontend
    
    These are some small bugs that fall under the scope of this branch. Other larger bugs that require separate issues are not fixed in this commit.
    pr1sm committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    bdd847c View commit details
    Browse the repository at this point in the history