Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DSM checkout #244

Closed
wants to merge 5 commits into from
Closed

Add DSM checkout #244

wants to merge 5 commits into from

Conversation

walmat
Copy link
Owner

@walmat walmat commented Jan 12, 2019


name: Add DSM Checkout Process
about: Integrates DSM UK / NY / SG / JP into task runner checkout process


Changes

  • Added frontend functions to checkout.js
    • AddToCart: handles frontend add to cart
    • ProceedToCheckout: handles a call to create the checkout session
    • ShippingRates: handled a if/else case to do frontend mode if necessary
    • SubmitCustomerInformation: handles the post to submit customer information
  • Small bug fixes in other places

Checks

fixes #238

@walmat walmat added the area:task-runner Related to Nebula's Task Runner package label Jan 12, 2019
@walmat walmat requested a review from pr1sm January 12, 2019 20:57
@pr1sm
Copy link
Collaborator

pr1sm commented Jan 16, 2019

After viewing these changes, I made a clarifying comment on the #238 thread.

I'm a little wary accepting the proposed changes, because the level of complexity of the checkout class increases quite a bit, while the readability drops. Combining both checkout methods together into one file/class is very confusing and I'm not sure it's the right solution to the issue.

I'm not sure when the next drop is coming, but if we have time, I would prefer we keep the two checkout methods split into separate files to reduce confusion.

@walmat
Copy link
Owner Author

walmat commented Jan 17, 2019

closing...

@walmat walmat closed this Jan 17, 2019
@walmat walmat deleted the issue_238 branch January 17, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:task-runner Related to Nebula's Task Runner package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Frontend Checkout
2 participants