Work around broken query parsing in merged configs #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a bug somewhere in webpack, another loader in the chain, or our config merging somehow.
In the webpack@1 version of
extract-text-webpack-plugin
, the loader chain must be a string, like so:css?foo!stylus?bar
. It can't be a list of objects like so:That means query options need to be serialized. For complex nested options, you're supposed to be able to do this, as demonstrated by @sokra:
This works in some versions of our archetype's webpack config. In others, we get this error:
Notice how the array gets turned into
[object Object]
– some module somewhere else in the chain is taking our perfectly fine JSON query, parsing it, then doing a terrible job re-serializating it, incorrectly, before it even gets to us.So this PR introduces extra parsing of the
precacheImportVariables
option, which lets us specify it as a non-JSON query string by doing an extraparseQuery
. 😠/cc @ananavati @jmcriffey