forked from jetstack/navigator
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move seed pod labelling to a separate controller
* In jetstack#256 I want to refactor nodepool.Sync so that its only responsibility is to update the NodePool status. * And the seed labelling seems like it is a separate concern that can live in its own module. * With its own unit tests.
- Loading branch information
Showing
9 changed files
with
277 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| package seedlabeller | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/golang/glog" | ||
| appsv1beta1 "k8s.io/api/apps/v1beta1" | ||
| "k8s.io/client-go/kubernetes" | ||
| appslisters "k8s.io/client-go/listers/apps/v1beta1" | ||
| corelisters "k8s.io/client-go/listers/core/v1" | ||
| "k8s.io/client-go/tools/record" | ||
|
|
||
| "github.com/jetstack/navigator/pkg/apis/navigator/v1alpha1" | ||
| "github.com/jetstack/navigator/pkg/controllers/cassandra/service/seedprovider" | ||
| "github.com/jetstack/navigator/pkg/controllers/cassandra/util" | ||
| ) | ||
|
|
||
| type Interface interface { | ||
| Sync(*v1alpha1.CassandraCluster) error | ||
| } | ||
|
|
||
| type defaultSeedLabeller struct { | ||
| kubeClient kubernetes.Interface | ||
| statefulSetLister appslisters.StatefulSetLister | ||
| pods corelisters.PodLister | ||
| recorder record.EventRecorder | ||
| } | ||
|
|
||
| var _ Interface = &defaultSeedLabeller{} | ||
|
|
||
| func NewControl( | ||
| kubeClient kubernetes.Interface, | ||
| statefulSetLister appslisters.StatefulSetLister, | ||
| pods corelisters.PodLister, | ||
| recorder record.EventRecorder, | ||
| ) Interface { | ||
| return &defaultSeedLabeller{ | ||
| kubeClient: kubeClient, | ||
| statefulSetLister: statefulSetLister, | ||
| pods: pods, | ||
| recorder: recorder, | ||
| } | ||
| } | ||
|
|
||
| func (c *defaultSeedLabeller) labelSeedNodes( | ||
| cluster *v1alpha1.CassandraCluster, | ||
| set *appsv1beta1.StatefulSet, | ||
| ) error { | ||
| // TODO: make number of seed nodes configurable | ||
| pod, err := c.pods.Pods(cluster.Namespace).Get(fmt.Sprintf("%s-%d", set.Name, 0)) | ||
| if err != nil { | ||
| glog.Warningf("Couldn't get stateful set pod: %v", err) | ||
| return nil | ||
| } | ||
| labels := pod.Labels | ||
| value := labels[seedprovider.SeedLabelKey] | ||
| if value == seedprovider.SeedLabelValue { | ||
| return nil | ||
| } | ||
| if labels == nil { | ||
| labels = map[string]string{} | ||
| } | ||
| labels[seedprovider.SeedLabelKey] = seedprovider.SeedLabelValue | ||
| podCopy := pod.DeepCopy() | ||
| podCopy.SetLabels(labels) | ||
| _, err = c.kubeClient.CoreV1().Pods(podCopy.Namespace).Update(podCopy) | ||
| return err | ||
| } | ||
|
|
||
| func (c *defaultSeedLabeller) Sync(cluster *v1alpha1.CassandraCluster) error { | ||
| sets, err := util.StatefulSetsForCluster(cluster, c.statefulSetLister) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| for _, s := range sets { | ||
| err = c.labelSeedNodes(cluster, s) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } |
Oops, something went wrong.