possible contributions to ol3-popup

[eblondel]

Hello, first of all many thank for this plugin, it helps a lot. We have been using your plugin in our project. However for some needs we had to extent it, successfully, on several aspects, that i here list below:

• Support for adding HTMLDivElement as part of content (not only a html string) - add support to HTMLElement as content html + isOpened() util method #18
• add utility method "isOpened" - add isOpened convenience method #19
• Option for tooltip management (to make a tooltip overlay e.g. for vector layers) - #17 support popup tooltip mode #20
• a mechanism to optimize the popup position and arrow (e.g. at global level, when we open a popup, this one will "stay" above the map but displayed below instead of above the event location).

We would not like to let this as fork, but rather to contribute it. Let me know if you are interested, in which case i could do it as proper fork in github, and pull request to share with you.

Best,
Emmanuel

[walkermatt]

@eblondel good to hear from you and glad the popup has been of use. I'm open to contributions. To make things straightforward could you create a separate PR for each enhancement.

I'm keen to keep things simple and avoid adding dependencies as much as possible but the enhancements you're suggesting all sound sensible.

Thanks,

Matt.

[eblondel]

Many thanks @walkermatt for your prompt feedback. I was thinking exactly as you said, one separate PR for each enhancement. I will start ASAP. Do you want me to create separate "issues" as well? Let me know

[walkermatt]

Happy for you to just create pull requests and for any discussion to occur there.

[eblondel]

Hi @walkermatt, thanks a lot for merging the first PRs. For the tooltip management option, i prefer explaining and discuss here, and the reason of the approach i'm going to suggest:

The option to enable the popup as tooltip is very basic and consists in having a boolean option isTooltip and conditioning some piece of the js code if it's a default popup (in particular the closer element and event).

Given the fact the js plugin handles 2 distinct css classes ol-popup and ol-popup-content, i let this as it is, and didn't enable a css classname as option. Maybe it could be useful, i don't know.
But at least, since in a same application we may need both popup and tooltip-popup, so far i handled this with a separate css stylesheet and classes ol-tooltip, and the js code just switch classes from ol-popup-* to ol-tooltip-* in case it's a tooltip..

I'd like to know if you agree with this approach.

[walkermatt]

Using CSS classes sounds sensible. How are you positioning the tooltip, are you paying the mouse coordinate and letting the tooltip decide where best to display?

[eblondel]

Ups, seems my reply didn't arrived here...:

To be clear, the ol-tooltip class is very similar to ol-popup.. smaller, with an arrow. and because it is a tooltip, there is no closer element, and it aims to be triggered on map event. (same as for a normal popup). Depending on the map event you have: e.g. a feature layer, the tooltip will show if your pointer is above a feature. (i wish to add also a new example for this)

There is no additional rule to decide where best to display. The tooltip popup mais to "follows" your mouse position in this case (but the event registration is up to the user).

The "dynamic" position is another thing i did (as option only, and disabled by default) to the popup that allows the popup to be either shown at bottom or top (at now it's fixed on top, with arrow at bottom of the popup) depending on where you are on the map and if there is enough space to display the popup. That is the last PR i wanted to share with you...

But maybe the best is that i share the 2 PR, so you can see directly..

[eblondel]

To be clear, the ol-tooltip class is very similar to ol-popup.. smaller,
with a an arrow. and because it is a tooltip, there is no closer
element. That's all. And it aims to be triggered on map event.

There is no additional rule to decide where best to display. This is
another thing i did as /option/ to the popup (for a separate PR) that
allows the popup to be either shown at bottom or top (at now it's fixed
on top) depending on where you are on the map and if there is enough
space to display the popup.

Le 22/10/2016 à 08:56, Matt Walker a écrit :

Using CSS classes sounds sensible. How are you positioning the
tooltip, are you paying the mouse coordinate and letting the tooltip
decide where best to display?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/walkermatt/ol3-popup/issues/17#issuecomment-255511715,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQ1bKx80YZa6KYqnL1QGFCGt3bVGz8Fks5q2bOOgaJpZM4KSaiz.

[walkermatt]

Sounds good to me, if you include an example in the PR then that would make it easier to review.