Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter to deANA #11

Merged
merged 1 commit into from
Jun 7, 2023
Merged

add filter to deANA #11

merged 1 commit into from
Jun 7, 2023

Conversation

sdgamboa
Copy link
Contributor

@sdgamboa sdgamboa commented Jun 6, 2023

@lwaldron, in reply to this comment, I found that the filter.by.expr = TRUE argument was added to the deANA function on a date after the manuscript was submitted and published (May/March 2019) in this commit (July 2019). This argument removed many OTUs. I changed the argument to FALSE (this PR), so that the OTUs were retained, and I was able to reproduce some of the GSEA results reported in the paper.

@sdgamboa sdgamboa requested a review from lwaldron June 6, 2023 22:05
@lwaldron lwaldron merged commit 310113c into main Jun 7, 2023
@lwaldron
Copy link
Member

lwaldron commented Jun 7, 2023

Good find @sdgamboa !

@sdgamboa sdgamboa deleted the sdgamboa/add-filter branch June 7, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants