Fix parameter index bug during function parsing and generalize test #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
khatchad
commented
Jun 6, 2023
•
khatchad
commented
- The source positions are incorrect when there are multiple explicit parameters; the second one gets the same position as the first. For example, we would get A.py [4:8] -> [4:9] twice for two different parameters.
- Make the TF2 tensor analysis tests more general to allow more flexibility in input test file structure.
The source positions are incorrect when there are multiple explicit paramters; the second one gets the same position as the first. For example, we would get A.py [4:8] -> [4:9] twice for two different parameters.
Will allow us to have different file structures but reuse the same test.
khatchad
changed the title
|
@msridhar If you can review this one, we have some more TF2 stuff to add. It uses the generalize tests though found in this PR. Thanks! |
msridhar
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.