Minor changes #38
Merged
Minor changes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
khatchad
commented
May 16, 2023
•
khatchad
commented
- Ignore temporary output.
- Fix whitespace error in README.md.
- Remove Eclipse preference (done automatically by more recent Eclipse version).
- Propagate exception cause.
- Don't trim stack traces.
These are being used as JARs now.
Since wala/ML is now using JAR packaging, this probably doesn't matter. However, it fixes the warnings. And, if it ever gets OSGi component packaged again, we can use it.
Source and data directiories don't exist for these subprojects.
Was removed by newer version of Eclipse.
Looks like the exception is being swallowed.
* Setting trimStackTrace to false * Temporarily adding the build failure * Put back the failing file --------- Co-authored-by: Raffi Khatchadourian <raffi.khatchadourian@hunter.cuny.edu>
|
Let's merge the latest master branch to check CI here? |
|
Done. |
msridhar
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.